containerized-data-importer
containerized-data-importer copied to clipboard
kubevirt
Support putting external images into the local registry of the kubevirtci cluster (#3801)
User can define an environment variable EXTRA_IMAGES that contains a list of external image urls separated by spaces.
At the end of 'make cluster-up' target the EXTRA_IMAGES are processed by a script ./cluster-up/extra-images.sh so that for each image url, it pulls the image and then push the image into the local registry.
Then when 'make cluster-sync' is invoked, it searches all external image urls in the generated yamls in _out/manifests/ and replaces them with corresponding urls in the local registry (registry:5000)
What this PR does / why we need it:
Added functionality for cluster-up target to allow adding external images to the internal local docker registry
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3801
Special notes for your reviewer:
Release note:
Normal users should not affected by this feature. Only users with isolated environments can use this feature to add
any external images to the local registry. Make sure your local machine have access to the external repositories in order to pull them and push to the local registry.
Hi @gaohoward. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@awels Hi Alex, just updated the branch. Pls take a look and see if it looks better. Thanks!
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale