containerized-data-importer
containerized-data-importer copied to clipboard
kubevirt
add IBM Block Storage CSI driver support for RWX
What this PR does / why we need it: add IBM Block Storage CSI driver support for RWX in the default storage profile. this is required, as upcoming IBM Block Storage CSI driver will add support for RWX. We have several customers that would like to Beta test the upcoming IBM Block Storage CSI driver release, specifically for VM virtualization and live-migration, and we need Openshift to be updated accordingly
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Add RWX to the IBM Block Storage CSI driver default storage profile
Special notes for your reviewer:
Release note:
IBM Block Storage CSI driver now supports RWX access mode
Hi @kasserater. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@kasserater: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/ok-to-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@arnongilboa can you please review this PR? we have multiple customers waiting to Beta test OCP with IBM Block Storage CSI driver with RWX support, specifically for VM Virtualization and live-migration. Successful beta tests can lead to large customer wins for both RH and IBM
coverage: 59.008% (+0.03%) from 58.983% when pulling 1eb785f83faa8822962f0c0d21b3baffe93a2ac1 on kasserater:main into 5195176c162e0dec07b786ee21d1267d610cd92a on kubevirt:main.
@kasserater: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@arnongilboa seems like some CI issue in the test. i can't seem to retrigger the tests. can you please assist? also, how can we make sure this IS NOT merged once all tests are completed? we want to make sure it is released in tandem with the IBM Block Storage CSI driver... finally, is there a way to bypass the code, for the Beta tests only, so that VMs can utilize live-migration with our IBM Block Storage CSI driver?
@arnongilboa seems like some CI issue in the test. i can't seem to retrigger the tests. can you please assist?
sure, we'll retest once we unhold it
also, how can we make sure this IS NOT merged once all tests are completed? we want to make sure it is released in tandem with the IBM Block Storage CSI driver...
it's on hold until the driver is released
finally, is there a way to bypass the code, for the Beta tests only, so that VMs can utilize live-migration with our IBM Block Storage CSI driver?
you can build based on your own branch for your tests
Users can also specify their own spec in the storage profile. That is our escape mechanism for unknown storage drivers. You could write some documentation on how to specify the correct values for your driver.
thank you @awels . this is what we will recommend our Beta customers and in our official documentation once we GA, until this PR is merged.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: awels
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [awels]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@awels once we approve this PR, it will be merged into the main branch which is for 4.18, correct? is there a cherry-pick/backport process to include this in all releases from 4.14 through 4.17? those are the releases we will support in the upcoming IBM Block Storage CSI driver release in support of RWX
Actually we just released a 1.61 release branch which is 4.18. So we would have to backport to that branch.
@kasserater: The label(s) /remove-label do-not-merge/hold cannot be applied. These labels are supported: good-first-issue, needs-approver-review. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/remove-label do-not-merge/hold
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@akalenyu: new pull request created: #3546
In response to this:
/cherrypick release-v1.61
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@akalenyu what OCP versions use release 1.61? what additional cherry-picks are required, if any, to have this change in all OCP releases from 4.14 onwards?
@akalenyu: new pull request created: #3548
In response to this:
I can help with that /cherrypick release-v1.60
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.