containerized-data-importer icon indicating copy to clipboard operation
containerized-data-importer copied to clipboard

Update to k8s 1.29 libs

Open mhenriks opened this issue 1 year ago • 6 comments

What this PR does / why we need it:

Newer libs, not the latest (1.30) because OpenShift isn't using it yet

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1097

Special notes for your reviewer:

Release note:

1.29 k8s libs

mhenriks avatar May 17 '24 21:05 mhenriks

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from mhenriks. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar May 17 '24 21:05 kubevirt-bot

@awels I think FOSSA is lying, giving this a rerun /test pull-containerized-data-importer-fossa

akalenyu avatar May 22 '24 12:05 akalenyu

If it fails again, I can investigate the issue with fossa.

awels avatar May 22 '24 12:05 awels

@mhenriks: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerized-data-importer-fossa fd3f643ec21db5a0c977e8a2be430877373d9eb9 link true /test pull-containerized-data-importer-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kubevirt-bot avatar May 22 '24 12:05 kubevirt-bot

/hold

have to change client generation code for 1.30

mhenriks avatar May 23 '24 04:05 mhenriks

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar May 31 '24 03:05 kubevirt-bot

closing in favor of #3336

mhenriks avatar Jul 05 '24 21:07 mhenriks