containerized-data-importer icon indicating copy to clipboard operation
containerized-data-importer copied to clipboard

Improve handling of unpopulated capacity field in clone populator

Open alromeros opened this issue 11 months ago • 6 comments

What this PR does / why we need it:

This is part of a larger work to improve log reporting in CDI.

There is a short window of time where a bound PVC can have an unpopulated capacity field in its status. The clone-populator handles this case by returning an error.

This approach is overkill as the issue is usually fixed instantly and should hardly be considered an error as we will reconcile again once the status is updated. This pull request aims to improve the handling of this case and adds unit test coverage.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # https://issues.redhat.com/browse/CNV-35803

Special notes for your reviewer:

Release note:

Improve handling of unpopulated capacity field in clone populator

alromeros avatar Mar 05 '24 19:03 alromeros

/test pull-cdi-unit-test

alromeros avatar Mar 05 '24 20:03 alromeros

/test pull-cdi-unit-test

alromeros avatar Mar 06 '24 10:03 alromeros

/retest-required

alromeros avatar Mar 06 '24 11:03 alromeros

/retest-required

alromeros avatar Mar 06 '24 13:03 alromeros

/test pull-cdi-unit-test

alromeros avatar Mar 06 '24 16:03 alromeros

/lgtm /approve

mhenriks avatar Mar 20 '24 14:03 mhenriks

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Mar 20 '24 14:03 kubevirt-bot