Fix that the Resources configuration is missing the configuration of …

[mzzgaopeng]

What this PR does / why we need it: Fix that the Resources configuration is missing the configuration of the initcontainer container

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # https://github.com/kubevirt/containerized-data-importer/issues/1043 Special notes for your reviewer:

Release note:

Fix that the Resources configuration is missing the configuration of the initcontainer container

  initContainers:
  - command:
    - sh
    - -c
    - cp /usr/bin/cdi-containerimage-server /shared/server
    image: quay.io/kubevirt/cdi-importer:v1.58.0
    imagePullPolicy: IfNotPresent
    name: init
    resources: {}
    securityContext:
      allowPrivilegeEscalation: false
      capabilities:
        drop:
        - ALL
      runAsNonRoot: true
      runAsUser: 107
      seccompProfile:
        type: RuntimeDefault
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /shared
      name: shared-volume
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: kube-api-access-csqcd
      readOnly: true

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

Hi @mzzgaopeng. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akalenyu]

Hey, thanks, the approach makes sense Can you please sign your commit, for example, with git commit --amend -s

[akalenyu]

Also if you can add a unit test in pkg/controller/import-controller_test.go that checks the pod gets created correctly, that would be awesome :pray: You should be able to update the CDIConfig object with resources as it's already a part of the unit test environment

[akalenyu]

oh and btw, and we usually develop on the main branch and only backport to release branches once things are merged there. so I think you can just change the target branch on the pull request

[mzzgaopeng]

Hey, thanks, the approach makes sense Can you please sign your commit, for example, with git commit --amend -s

how to sign my commit？

[akalenyu]

Hey, thanks, the approach makes sense Can you please sign your commit, for example, with git commit --amend -s

how to sign my commit？

git commit --amend -s Should work

[mzzgaopeng]

Hey, thanks, the approach makes sense Can you please sign your commit, for example, with git commit --amend -s

how to sign my commit？

git commit --amend -s Should work

The signature information has been submitted. Do you still need to submit the test cases？

[akalenyu]

Hey, thanks, the approach makes sense Can you please sign your commit, for example, with git commit --amend -s

how to sign my commit？

git commit --amend -s Should work

The signature information has been submitted. Do you still need to submit the test cases？

Yes, that would be great, thank you Could you please also change the target branch to main?

[awels]

/test all

[mzzgaopeng]

Do I need to resubmit a PR？

[akalenyu]

Do I need to resubmit a PR？

No no, you can just click "Edit" above the title and this field becomes a editable I can do this for you, let me try EDIT: So there are some conflicts probably because you started out from release-v1.58. Could you try applying this change on main, and pushing? Feel free to ping me on Slack if you need any help

[kubevirt-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awels]

@mzzgaopeng The PR needs a rebase if you could do a rebase that would be great.

[mzzgaopeng]

There are a lot of changes in rebase, how to merge it into main again?

[mzzgaopeng]

There are a lot of changes in rebase, how to merge it into main again?

update to https://github.com/kubevirt/containerized-data-importer/pull/3157

[akalenyu]

There are a lot of changes in rebase, how to merge it into main again?

update to https://github.com/kubevirt/containerized-data-importer/pull/3157

thanks! we will use the bot to cherry pick /close

[kubevirt-bot]

@akalenyu: Closed this PR.

In response to this:

There are a lot of changes in rebase, how to merge it into main again?

update to https://github.com/kubevirt/containerized-data-importer/pull/3157

thanks! we will use the bot to cherry pick /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.