containerized-data-importer
containerized-data-importer copied to clipboard
kubevirt
[release-v1.43] Manual backport of 'Allow creating clones without source PVC (#2306)'
What this PR does / why we need it:
Manual backport of #2306
Release note:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign aglitke after the PR has been reviewed.
You can assign the PR to them by writing /assign @aglitke in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@alromeros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-containerized-data-importer-e2e-ceph-gc | c6c7e857e4286a149698b060551de33c7b27efdb | link | true | /test pull-containerized-data-importer-e2e-ceph-gc |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@alromeros did you have to do many manual changes to adapt the 2306 to this release?
@brybacki Yeah I had to adapt some newer clone-related code to the old datavolume controller. It wasn't a lot but it required some rework.
/hold
As in #2366, holding since we have yet to reach a consensus on whether to backport this feature or not. The general idea seemed to be not doing it, which I'm not against, but I'll leave the PR open for some time just in case.
@alromeros: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Since https://github.com/kubevirt/containerized-data-importer/pull/2405 was merged, this backport is no longer necessary. I'm closing the PR.