containerized-data-importer
containerized-data-importer copied to clipboard
kubevirt
[release-v1.49] Manual backport of 'Allow creating clones without source PVC (#2306)'
What this PR does / why we need it:
Manual backport of #2306
Release note:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign awels after the PR has been reviewed.
You can assign the PR to them by writing /assign @awels in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-ceph-gc
In response to this:
/override pull-containerized-data-importer-e2e-ceph-gc
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/lgtm looks good, but I think you need to coordinate changes with @ShellyKa13, on this PR https://github.com/kubevirt/containerized-data-importer/pull/2406 I do not now which change should go first. Probably this one
/hold
Holding since we have yet to reach a consensus on whether to backport this feature or not. The general idea seemed to be not doing it, which I'm not against, but I'll leave the PR open for some time just in case.
@alromeros: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Since https://github.com/kubevirt/containerized-data-importer/pull/2406 was merged, this backport is no longer necessary. I'm closing the PR.