containerized-data-importer icon indicating copy to clipboard operation
containerized-data-importer copied to clipboard

Published 20 hours ago • verified publisher icon kubevirt

Address possible nils in dv controller, log CSIDrivers in tests

Open akalenyu opened this issue 2 years ago • 15 comments

Signed-off-by: Alex Kalenyuk [email protected]

What this PR does / why we need it:

  • Handle some storageClassName nils
  • We'd expect the CSIDriver object to be there, otherwise ceph install might be struggling

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE

akalenyu avatar May 01 '22 11:05 akalenyu

/test pull-containerized-data-importer-e2e-ceph

akalenyu avatar May 01 '22 11:05 akalenyu

/test pull-containerized-data-importer-e2e-ceph

akalenyu avatar May 01 '22 16:05 akalenyu

/test pull-containerized-data-importer-e2e-ceph

akalenyu avatar May 02 '22 08:05 akalenyu

/test pull-containerized-data-importer-e2e-ceph

akalenyu avatar May 02 '22 11:05 akalenyu

/test pull-containerized-data-importer-e2e-ceph

akalenyu avatar May 02 '22 14:05 akalenyu

/test all

akalenyu avatar May 02 '22 17:05 akalenyu

/test all

akalenyu avatar May 02 '22 22:05 akalenyu

/test all

akalenyu avatar May 03 '22 08:05 akalenyu

/retest

akalenyu avatar May 03 '22 10:05 akalenyu

/test pull-cdi-apidocs

brybacki avatar May 27 '22 10:05 brybacki

Does this still need to get in or did we solve it some other way?

awels avatar Jul 08 '22 12:07 awels

Does this still need to get in or did we solve it some other way?

This NPE is still possible afaik

akalenyu avatar Jul 10 '22 11:07 akalenyu

/retest

awels avatar Aug 03 '22 13:08 awels

I think now it looks really good, just one question about source PVC storage class.

brybacki avatar Oct 03 '22 11:10 brybacki

I think now it looks really good, just one question about source PVC storage class.

ping - I think this is pretty harmless and spares us from nil panics

akalenyu avatar Oct 19 '22 10:10 akalenyu

/lgtm

brybacki avatar Oct 19 '22 11:10 brybacki

/approve

awels avatar Oct 19 '22 12:10 awels

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Oct 19 '22 12:10 kubevirt-bot