containerdisks icon indicating copy to clipboard operation
containerdisks copied to clipboard

CI should run promote with dry run disabled

Open codingben opened this issue 1 year ago • 3 comments

CI is running promote stage in dry run, it means dry run is enabled and the actual code that is pushing the image to remote container registry is not executed. We should improve testing of it, and not use dry run in CI to test changes [1].

[1] https://github.com/kubevirt/containerdisks/blob/main/pipeline.sh#L13

codingben avatar Mar 28 '24 14:03 codingben

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jun 26 '24 15:06 kubevirt-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot avatar Jul 26 '24 15:07 kubevirt-bot

/remove-lifecycle stale

codingben avatar Jul 27 '24 12:07 codingben

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot avatar Aug 26 '24 12:08 kubevirt-bot

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Aug 26 '24 12:08 kubevirt-bot