community icon indicating copy to clipboard operation
community copied to clipboard

design-proposal: instancetype.kubevirt.io - Support declarative VirtualMachine management

Open lyarwood opened this issue 1 year ago • 1 comments

What this PR does / why we need it:

At present a VirtualMachine using instance types and/or preferences will have runtime derived data such as the name of a ControllerRevision capturing the state of each resource mutated into the core spec during submission.

This breaks declarative management of VirtualMachines as an owner has no way of pre-populating these runtime derived values and will always see changes made to the spec of their VirtualMachine after submission.

This design proposal aims to enable declarative management of VirtualMachines using instance types and/or preferences by using status to track runtime derived data while retaining all existing behavior and lifecycle support of a VirtualMachine using an instance type and/or preference.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE

lyarwood avatar Aug 19 '24 11:08 lyarwood

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Aug 19 '24 11:08 kubevirt-bot

/sig compute

xpivarc avatar Nov 18 '24 15:11 xpivarc

@lyarwood is this just waiting on re-reviews after changes?

aburdenthehand avatar Jan 15 '25 14:01 aburdenthehand

/close

lyarwood avatar Mar 12 '25 14:03 lyarwood

@lyarwood: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Mar 12 '25 14:03 kubevirt-bot