community
community copied to clipboard
kubevirt
community, wg, arch: add wg, sig subprojects and charter for S390x and ARM
What this PR does / why we need it:
PR #301 will add the folder wg-TEMPLATE as a starting point for creating working groups.
This PR (based on #301) adds two initial wg-arch working groups:
- wg-arch-s390x
- wg-arch-arm to define chairs and leads on S390x and ARM.
Also it defines subprojects in sig-buildsystem and sig-ci, so that arch wg members can own code.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Note: This PR is based on #301 and needs to get rebased after #301 got merged!
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
/hold
PR https://github.com/kubevirt/community/pull/301 was split out of this one, so this needs to be rebased after that one got merged.
FYI @fabiand
@chandramerla: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@cfilleke: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dhiller is the hold still relevant?
Thanks for the reminder :) Yeah, I think a rebase is needed here, other than that it should be good to go. @jean-edouard will ping you again after that's done if you're ok with that?
/unhold
@chandramerla @cfilleke @zhlhahaha I have rebased this PR, PTAL, thanks a lot!
@jean-edouard FYI
/approve /cc @jschintag @cfilleke @vamsikrishna-siddu @chandramerla @zhlhahaha
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jean-edouard
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jean-edouard]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@cfilleke: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@lyarwood since you had been involved for a bit, would you mind taking another look and see whether this is good to go?
Thank you!
@chandramerla :wave: would you mind taking another look here? We should be good from my POV.
@chandramerla 👋 would you mind taking another look here? We should be good from my POV.
Sorry I didn't check the message in time. Changes wise it looks good and anyway it is merged already.