cluster-network-addons-operator icon indicating copy to clipboard operation
cluster-network-addons-operator copied to clipboard

feat: enable download of go client for host arch

Open nestoracunablanco opened this issue 1 year ago • 4 comments

This commit is a step towards enabling builds for different architectures.

What this PR does / why we need it: s390x enablement

Special notes for your reviewer:

Release note:


nestoracunablanco avatar Sep 19 '24 08:09 nestoracunablanco

Hi @nestoracunablanco. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Sep 19 '24 08:09 kubevirt-bot

@qinqon @RamLavi what do you think about this change?

nestoracunablanco avatar Sep 24 '24 08:09 nestoracunablanco

/ok-to-test

RamLavi avatar Sep 24 '24 17:09 RamLavi

/lgtm

RamLavi avatar Sep 26 '24 07:09 RamLavi

/approve

RamLavi avatar Sep 26 '24 10:09 RamLavi

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Sep 26 '24 10:09 kubevirt-bot