cloud-provider-kubevirt icon indicating copy to clipboard operation
cloud-provider-kubevirt copied to clipboard

Support Local ExternalTrafficPolicy

Open hdurand0710 opened this issue 3 years ago • 24 comments

As mentioned in this ticket: https://github.com/kubevirt/cloud-provider-kubevirt/issues/15, EnsureLoadBalancer can only support an ExternalTrafficPolicy=Cluster. It would also require:

  • Do not label the proxy pod/VMI where actual pod does not exist
  • React on endpoint updates (if the actual pod is rescheduled on a different node)

Is there a plan to fix this issue to have ExternalTrafficPolicy=Local work ? We for example have this ticket opened https://github.com/kubermatic/kubermatic/issues/9022 by our customer that would like to use the Local externalTrafficPolicy.

hdurand0710 avatar Feb 18 '22 13:02 hdurand0710

Hi @hdurand0710, I agree that there is probably something wrong with the labelling of pods/VMIs.

However, there are currently no plans to fix this, since I do not have a proper dev environment available at the moment. Of course, PRs fixing this are welcome :)

gonzolino avatar Feb 22 '22 10:02 gonzolino

/assign @mfranczy

mfranczy avatar Apr 06 '22 11:04 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jul 05 '22 12:07 kubevirt-bot

/remove-lifecycle stale

hdurand0710 avatar Jul 05 '22 12:07 hdurand0710

/remove-lifecycle stale

mfranczy avatar Jul 07 '22 09:07 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Oct 05 '22 09:10 kubevirt-bot

/remove-lifecycle stale

hdurand0710 avatar Oct 05 '22 09:10 hdurand0710

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jan 03 '23 10:01 kubevirt-bot

/remove-lifecycle stale

hdurand0710 avatar Jan 03 '23 10:01 hdurand0710

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Apr 03 '23 10:04 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Apr 03 '23 10:04 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jul 02 '23 10:07 kubevirt-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot avatar Aug 01 '23 11:08 kubevirt-bot

/remove-lifecycle rotten

mfranczy avatar Aug 01 '23 12:08 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Oct 30 '23 12:10 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Nov 06 '23 15:11 mfranczy

@mfranczy Are you still working on this? Anything anyone else can help with? This is a fairly important feature for us, so happy to provide assistance.

timstoop avatar Jan 03 '24 12:01 timstoop

@timstoop currently I have no bandwidth for that. IMO there should be another controller that watches for endpoints in the tenant cluster and updates the endpoint in the infra cluster. If you're willing to contribute to that we can sync on CAPK upstream meeting.

mfranczy avatar Jan 03 '24 13:01 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Apr 02 '24 14:04 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Apr 05 '24 07:04 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jul 04 '24 08:07 kubevirt-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot avatar Aug 03 '24 09:08 kubevirt-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot avatar Sep 02 '24 09:09 kubevirt-bot

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Sep 02 '24 09:09 kubevirt-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot avatar Oct 02 '24 09:10 kubevirt-bot

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Oct 02 '24 09:10 kubevirt-bot

/reopen

fix is ready to review https://github.com/kubevirt/cloud-provider-kubevirt/pull/330

kvaps avatar Oct 02 '24 10:10 kvaps

@kvaps: Reopened this issue.

In response to this:

/reopen

fix is ready to review https://github.com/kubevirt/cloud-provider-kubevirt/pull/330

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Oct 02 '24 10:10 kubevirt-bot