cloud-provider-kubevirt icon indicating copy to clipboard operation
cloud-provider-kubevirt copied to clipboard

Lookup for VMI by hostname

Open mfranczy opened this issue 2 years ago • 22 comments

The current implementation doesn't work as expected, it fails with:

that match label selector "", field selector "spec.Hostname=testmachine": field label not supported: spec.Hostname

mfranczy avatar Jul 27 '22 11:07 mfranczy

/assign @mfranczy

mfranczy avatar Jul 27 '22 11:07 mfranczy

/kind bug

mfranczy avatar Jul 27 '22 11:07 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Oct 25 '22 12:10 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Nov 16 '22 15:11 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Feb 14 '23 16:02 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Feb 28 '23 12:02 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar May 29 '23 13:05 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar May 30 '23 08:05 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Aug 28 '23 08:08 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Aug 31 '23 09:08 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Nov 29 '23 10:11 kubevirt-bot

/remove-lifecycle stale

mfranczy avatar Nov 30 '23 18:11 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Feb 28 '24 18:02 kubevirt-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot avatar Mar 29 '24 19:03 kubevirt-bot

/remove-lifecycle rotten

mfranczy avatar Apr 05 '24 07:04 mfranczy

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jul 04 '24 08:07 kubevirt-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot avatar Aug 03 '24 09:08 kubevirt-bot

I stumbled across this issue where the node in the tenant cluster is identified by an FQDN (test-control-plane-2cqlx.tools4.svc.salt.cluster.lan) instead of just the hostname (test-control-plane-2cqlx). Due to this, the node.kubernetes.io/instance-id label, which should be provided by the provider, is missing, and the fallback mechanism shown below is not working.

Additionally, I noticed that the version of kubevirt.io/api being used is v0.59.0, which is outdated. The current version is v1.3.0. Because of this outdated API version, the fallback won’t function as expected.

	lo := &client.ListOptions{
		Namespace:     namespace,
		FieldSelector: fields.SelectorFromSet(fields.Set{"spec.hostname": hostname}),
	}

https://github.com/kubevirt/cloud-provider-kubevirt/blob/adbd6c27468b86b020cf38490e84f124ef24ab62/pkg/provider/instances_getter.go#L39C1-L42C3

JSchlarb avatar Aug 17 '24 09:08 JSchlarb

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot avatar Sep 16 '24 09:09 kubevirt-bot

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Sep 16 '24 09:09 kubevirt-bot

/reopen

mfranczy avatar Sep 16 '24 17:09 mfranczy

@mfranczy: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Sep 16 '24 17:09 kubevirt-bot