kubevela icon indicating copy to clipboard operation
kubevela copied to clipboard

fix: missing comma ok

Open Awadabang opened this issue 1 year ago • 1 comments

Description of your changes

Fix a "comma-sytle" bug. I've checked other place to prevent similar bugs.

I have:

  • [x] Read and followed KubeVela's contribution process.
  • [ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • [ ] Run make reviewable to ensure this PR is ready for review.
  • [ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Awadabang avatar Feb 06 '24 09:02 Awadabang

Codecov Report

Attention: Patch coverage is 50.00000% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 55.36%. Comparing base (42d75e0) to head (955f4d7). Report is 1 commits behind head on master.

:exclamation: Current head 955f4d7 differs from pull request most recent head 1256816. Consider uploading reports for the commit 1256816 to get more accurate results

Files Patch % Lines
....dev/v1beta1/application/application_controller.go 0.00% 18 Missing :warning:
pkg/velaql/context.go 0.00% 7 Missing :warning:
pkg/utils/parse.go 0.00% 5 Missing :warning:
pkg/definition/gen_sdk/gen_sdk.go 0.00% 2 Missing and 1 partial :warning:
pkg/workflow/providers/oam/apply.go 60.00% 2 Missing :warning:
pkg/addon/addon.go 80.00% 1 Missing :warning:
pkg/appfile/appfile.go 0.00% 1 Missing :warning:
pkg/utils/apply/apply.go 0.00% 1 Missing :warning:
pkg/velaql/providers/query/handler.go 80.00% 1 Missing :warning:
pkg/velaql/view.go 50.00% 1 Missing :warning:
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6457       +/-   ##
===========================================
- Coverage   65.49%   55.36%   -10.13%     
===========================================
  Files         183      158       -25     
  Lines       23885    22955      -930     
===========================================
- Hits        15643    12709     -2934     
- Misses       6657     8901     +2244     
+ Partials     1585     1345      -240     
Flag Coverage Δ
core-unittests 55.36% <50.00%> (+0.05%) :arrow_up:
e2e-multicluster-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 09:02 codecov[bot]