kubevela
kubevela copied to clipboard
Feat: enhanced horizontal scaling of app controller.
Signed-off-by: Xiangbo Ma [email protected]
Description of your changes
Fixes https://github.com/kubevela/kubevela/issues/4596
Add sharding for app controller, and legacy app cr will be processed by sharding-1. I have:
- [x] Read and followed KubeVela's contribution process.
- [ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
- [x] Run
make reviewable
to ensure this PR is ready for review. - [x] Added
backport release-x.y
labels to auto-backport this PR if necessary.
How has this code been tested
Special notes for your reviewer
Codecov Report
Merging #4705 (c1d01dd) into master (cea9ef5) will decrease coverage by
12.67%
. The diff coverage is7.14%
.
@@ Coverage Diff @@
## master #4705 +/- ##
===========================================
- Coverage 60.85% 48.18% -12.68%
===========================================
Files 322 266 -56
Lines 31725 28658 -3067
===========================================
- Hits 19307 13809 -5498
- Misses 9912 12887 +2975
+ Partials 2506 1962 -544
Flag | Coverage Δ | |
---|---|---|
apiserver-e2etests | ? |
|
apiserver-unittests | 40.48% <ø> (+0.03%) |
:arrow_up: |
core-unittests | 55.10% <7.14%> (+0.13%) |
:arrow_up: |
e2e-multicluster-test | ? |
|
e2e-rollout-tests | ? |
|
e2etests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
cmd/core/main.go | 9.46% <0.00%> (-0.24%) |
:arrow_down: |
...dev/v1alpha2/application/application_controller.go | 55.91% <16.66%> (-30.91%) |
:arrow_down: |
pkg/apiserver/domain/service/service.go | 0.00% <0.00%> (-92.31%) |
:arrow_down: |
pkg/workflow/workflow.go | 0.00% <0.00%> (-91.31%) |
:arrow_down: |
pkg/apiserver/interfaces/api/velaql.go | 4.16% <0.00%> (-83.34%) |
:arrow_down: |
pkg/controller/utils/actions.go | 0.00% <0.00%> (-80.00%) |
:arrow_down: |
pkg/apiserver/interfaces/api/payload_types.go | 5.55% <0.00%> (-77.78%) |
:arrow_down: |
pkg/auth/identity.go | 0.00% <0.00%> (-75.52%) |
:arrow_down: |
pkg/resourcekeeper/containsresources.go | 0.00% <0.00%> (-75.00%) |
:arrow_down: |
...v/v1alpha2/componentdefinition/mutating_handler.go | 0.00% <0.00%> (-74.00%) |
:arrow_down: |
... and 209 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Is it duplicated with #4618 ? Shall we close one?
Is it duplicated with #4618 ? Shall we close one?
ok
closing as https://github.com/kubevela/kubevela/pull/5360 merged