kubestone icon indicating copy to clipboard operation
kubestone copied to clipboard

FIX: Added explicit emptydir to fio base sample

Open julio-santiesteban opened this issue 6 years ago • 3 comments

PR #128 broke the current fio base example

julio-santiesteban avatar Nov 08 '19 12:11 julio-santiesteban

I'm not quite sure what was the original behavior, but from usability perspective the default mode of operation would be (at least from my side) would be to test the default storageClass. This change is making emptyDir as a default.

What's your take on this?

otto-von-bivouac avatar Nov 10 '19 14:11 otto-von-bivouac

My best guess is that the e2e test failed because now all the 3 fio tests (base, builtin / custom jobs) need a pvc, which takes more time.

julio-santiesteban avatar Nov 13 '19 07:11 julio-santiesteban

@julio-santiesteban if you can pull in the latest changes i will give this another review.

kalinon avatar Apr 14 '20 13:04 kalinon