website icon indicating copy to clipboard operation
website copied to clipboard

Added files for installing kubesphere on minikube issue #2134

Open enraiha0307 opened this issue 2 years ago • 9 comments

Added files for steps on installing /uninstalling kubesphere on minikube and its prerequisites, along with the video as well as terminal code demonstration. Please review.

enraiha0307 avatar Apr 26 '22 16:04 enraiha0307

Deploy Preview for kubesphere-v3-1 ready!

Name Link
Latest commit dcad2f84b173e36a1b0f89f07d83d7a14073cb7b
Latest deploy log https://app.netlify.com/sites/kubesphere-v3-1/deploys/628de377526f5900088b6790
Deploy Preview https://deploy-preview-2412--kubesphere-v3-1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 26 '22 16:04 netlify[bot]

Hi @enraiha0307 ,

Thanks for your contribution! I think it would be better to add this guide to this folder. It could be found from the on-premise category since Minikube is local K8s distribution that could be regarded as an on-premises solution. What do you think of it?

/cc @kubesphere/sig-docs

FeynmanZhou avatar Apr 26 '22 16:04 FeynmanZhou

/kind documentation

FeynmanZhou avatar Apr 26 '22 16:04 FeynmanZhou

Hi @enraiha0307 ,

Thanks for your contribution! I think it would be better to add this guide to this folder. It could be found from the on-premise category since Minikube is local K8s distribution that could be regarded as an on-premises solution. What do you think of it?

/cc @kubesphere/sig-docs

I think you are correct, I'll add it in on-prem-kubernetes folder

enraiha0307 avatar Apr 26 '22 17:04 enraiha0307

Hi @FeynmanZhou, I have added the guide in on-prem-kubernetes folder. Tell me if any more changes are needed.

enraiha0307 avatar Apr 26 '22 19:04 enraiha0307

Hi @enraiha0307,

Sorry for the late reply. I have reviewed this guide and your video, it looks quite professional! You can preview it here. I request to do the following updates:

  1. Do not remove this build.yml, it is used to create the CI/CD workflow.
  2. Please remove these three files since they are duplicated with other places. Just preserve one installation guide in the on-premises folder. image

FeynmanZhou avatar May 22 '22 08:05 FeynmanZhou

Hi @enraiha0307,

Sorry for the late reply. I have reviewed this guide and your video, it looks quite professional! You can preview it here. I request to do the following updates:

1. Do not remove this [build.yml](https://github.com/kubesphere/website/pull/2412/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721), it is used to create the CI/CD workflow.

2. Please remove these three files since they are duplicated with other places. Just preserve one installation guide in the `on-premises` folder.
   ![image](https://user-images.githubusercontent.com/40452856/169686603-531a9973-a2b4-4f92-8af9-0b44fd6347df.png)

Hi @FeynmanZhou I have preserved the guide to one page. And about the build.yml, I am not deleting it. It doesn't come when I rebase my branch on master. It only shows in the master branch.

enraiha0307 avatar May 25 '22 08:05 enraiha0307

@Patrick-LuoYu @harrisonliu5 Please help review this PR.

rayzhou2017 avatar Jun 12 '22 10:06 rayzhou2017

/lgtm /assign @patrickluoyu Pls help me merge this PR.

Bettygogo2021 avatar Oct 28 '22 10:10 Bettygogo2021

/lgtm /approve

patrickluoyu avatar Oct 31 '22 03:10 patrickluoyu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enraiha0307, patrickluoyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Oct 31 '22 03:10 ks-ci-bot