kubekey icon indicating copy to clipboard operation
kubekey copied to clipboard

Feat/pull image with multi arch

Open zuoxuesong-worker opened this issue 3 weeks ago • 4 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

when make offline package , we maybe only need amd64 and arm64 image but some image has other arch which we dont need change pull func , we can pull image with arch we want

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

pull image with multi arch

Does this PR introduced a user-facing change?

pull image with multi arch

Additional documentation, usage docs, etc.:


zuoxuesong-worker avatar Dec 04 '25 05:12 zuoxuesong-worker

This PR has multiple commits, and the default merge method is: squash. You can request commits to be merged using the label: tide/merge-method-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubesphere-prow[bot] avatar Dec 04 '25 05:12 kubesphere-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zuoxuesong-worker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [zuoxuesong-worker]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubesphere-prow[bot] avatar Dec 04 '25 05:12 kubesphere-prow[bot]

Summary of Changes

Hello @zuoxuesong-worker, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the image pulling functionality by introducing support for multi-architecture image selection. Previously, the system might pull all available architectures for an image, which is inefficient, especially when creating offline packages for specific environments. The new implementation allows users to specify desired architectures, ensuring that only the necessary image variants are downloaded and stored, leading to more streamlined and efficient image management.

Highlights

  • Multi-Architecture Image Pulling: Introduced the capability to pull container images for specific architectures, addressing the need to avoid downloading unnecessary architectures during offline package creation.
  • Flexible Platform Selection: The image pulling mechanism now accepts a list of desired platforms (e.g., "amd64", "arm64"), allowing for precise control over which image variants are downloaded.
  • Enhanced Image Manifest Handling: New internal logic has been implemented to parse OCI image indexes, filter individual manifests based on the specified architectures, and reconstruct a new image index containing only the relevant platform-specific images.
  • Configuration Update: The images.yaml configuration file has been updated to include a platform field, enabling users to define target architectures directly in their image pull configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 04 '25 05:12 gemini-code-assist[bot]