kubekey icon indicating copy to clipboard operation
kubekey copied to clipboard

feat: use set_fact to set binary_type

Open redscholar opened this issue 6 months ago • 2 comments

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  1. Use set_fact to set the binary_type instance of register.
  2. Fix duplicate parsing of the assert message.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


redscholar avatar Jun 19 '25 10:06 redscholar

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubesphere-prow[bot] avatar Jun 19 '25 10:06 kubesphere-prow[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jun 20 '25 06:06 sonarqubecloud[bot]