ks-devops
ks-devops copied to clipboard
Add API for FluxCD Application
What type of PR is this?
/kind feature /kind design /kind api-change
What this PR does / why we need it:
Add API for FluxCD Application.
Which issue(s) this PR fixes:
Fixes #777
Special notes for reviewers:
Please check the following list before waiting reviewers:
- [ ] Already committed the CRD files to the Helm Chart if you created some new CRDs
- [ ] Already added the permission for the new API
- [ ] Already added the RBAC markers for the new controllers
Does this PR introduce a user-facing change??
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Base: 57.38% // Head: 57.08% // Decreases project coverage by -0.29%
:warning:
Coverage data is based on head (
28a6f8b
) compared to base (11ee977
). Patch coverage: 92.16% of modified lines in pull request are covered.
:exclamation: Current head 28a6f8b differs from pull request most recent head 266532a. Consider uploading reports for the commit 266532a to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 57.38% 57.08% -0.30%
==========================================
Files 188 192 +4
Lines 11114 15257 +4143
==========================================
+ Hits 6378 8710 +2332
- Misses 4356 6165 +1809
- Partials 380 382 +2
Flag | Coverage Δ | |
---|---|---|
unittests | 57.08% <92.16%> (-0.30%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/kapis/gitops/v1alpha1/gitops/handler.go | 82.71% <82.71%> (ø) |
|
pkg/kapis/gitops/v1alpha1/argocd/handler.go | 96.00% <92.10%> (+9.33%) |
:arrow_up: |
pkg/kapis/gitops/v1alpha1/argocd/route.go | 100.00% <100.00%> (ø) |
|
pkg/kapis/gitops/v1alpha1/fluxcd/handler.go | 100.00% <100.00%> (ø) |
|
pkg/kapis/gitops/v1alpha1/fluxcd/route.go | 100.00% <100.00%> (ø) |
|
pkg/kapis/gitops/v1alpha1/gitops/util.go | 100.00% <100.00%> (ø) |
|
pkg/kapis/gitops/v1alpha1/registery.go | 100.00% <100.00%> (ø) |
|
pkg/apiserver/runtime/runtime.go | 46.42% <0.00%> (-9.83%) |
:arrow_down: |
...g/kapis/devops/v1alpha3/pipelinerun/listhandler.go | 61.53% <0.00%> (-5.13%) |
:arrow_down: |
...pis/devops/v1alpha3/webhook/workflowrun_handler.go | 75.75% <0.00%> (-4.25%) |
:arrow_down: |
... and 186 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I remain the POST GET LIST UPDATE DELETE API on Applications and remove /sync and /application-summary API that ArgoCD Exclusive to the argocd
directory.
It support both ArgoCD and FluxCD Applications now. And I will add API that FluxCD Exclusive like HelmTemplate in the fluxcd
directory in the future.
The only thing need to be changed in the frontend is the application kind (from 'argo-project' to 'argocd') https://github.com/chengleqi/kubesphere-console/commit/ba1d51cb904183d04b03b9779d4de0210cb40272
@lxm
@chengleqi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
- Extract public handler into
gitops
folder and Embed the public handler in bothargocd handler
andfluxcd handler
so these handler can use the public handler. - Add
--argocd
and--fluxcd
to instruct whether to register the corresponding routes. - Need to add
--argocd
flag in the ks-devops-helm-chart
- Extract public handler into
gitops
folder and Embed the public handler in bothargocd handler
andfluxcd handler
so these handler can use the public handler.- Add
--argocd
and--fluxcd
to instruct whether to register the corresponding routes.- Need to add
--argocd
flag in the ks-devops-helm-chart
great!
lgtm
but the codecov seems broken. @kubesphere/sig-devops