ks-devops icon indicating copy to clipboard operation
ks-devops copied to clipboard

Avoid calling Jenkins replay API in the apiserver

Open LinuxSuRen opened this issue 2 years ago • 2 comments

Considering Jenkins is just a CI engine for this project. We are going to remove all Jenkins API calling in the apiserver component.

The old API path: v1alpha2/devops/{project}/pipelines/{pipeline}/runs/{run}/replay/

I'd like to suggest a new API:

v1alpha3/namespaces/{namespace}/pipelineruns/{pipelinerun}/rerun

References

  • https://github.com/kubesphere/ks-devops/issues/772

/kind feature

LinuxSuRen avatar Aug 11 '22 05:08 LinuxSuRen

remove all Jenkins API and replace them with Jenkins SDK? Or just replace the URL route

mzmuer avatar Sep 07 '22 06:09 mzmuer

The point of this issue is that only the controller could communicate with Jenkins. The APIServer should only read and write the CRs.

LinuxSuRen avatar Sep 07 '22 07:09 LinuxSuRen

https://github.com/kubesphere/ks-devops/issues/714

chilianyi avatar Feb 15 '23 05:02 chilianyi

/close

chilianyi avatar Jul 24 '23 03:07 chilianyi

@chilianyi: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Jul 24 '23 03:07 ks-ci-bot