ks-devops
ks-devops copied to clipboard
Add Multi-Cluster Management for Flux Application
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add fluxcd/multi-cluster-controller to sync the cluster.kubesphere.io/clusters and kubeconfig secret which FluxCD Application(Kustomization and HelmRelease) needed for Multi-Cluster Management.
Which issue(s) this PR fixes:
Fixes #767
Special notes for reviewers:
Please check the following list before waiting reviewers:
- [ ] Already committed the CRD files to the Helm Chart if you created some new CRDs
- [ ] Already added the permission for the new API
- [x] Already added the RBAC markers for the new controllers
Does this PR introduce a user-facing change??
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Merging #769 (4dd3258) into master (5a189fa) will increase coverage by
1.44%
. The diff coverage is83.09%
.
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 53.70% 55.14% +1.44%
==========================================
Files 181 183 +2
Lines 10668 10891 +223
==========================================
+ Hits 5729 6006 +277
+ Misses 4623 4557 -66
- Partials 316 328 +12
Flag | Coverage Δ | |
---|---|---|
unittests | 55.14% <83.09%> (+1.44%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
controllers/fluxcd/multi-cluster-controller.go | 83.09% <83.09%> (ø) |
|
pkg/utils/net/net.go | 100.00% <0.00%> (ø) |
|
pkg/api/devops/v1alpha3/pipelinerun_types.go | 38.09% <0.00%> (ø) |
|
...rs/gitrepository/pull_request_status_controller.go | 86.11% <0.00%> (ø) |
|
.../jenkins/devopsproject/devopsproject_controller.go | 43.22% <0.00%> (+2.60%) |
:arrow_up: |
...ns/devopscredential/devopscredential_controller.go | 36.73% <0.00%> (+3.40%) |
:arrow_up: |
pkg/client/git/client.go | 100.00% <0.00%> (+15.38%) |
:arrow_up: |
cmd/controller/app/options/feature.go | 100.00% <0.00%> (+45.45%) |
:arrow_up: |
cmd/controller/app/options/options.go | 100.00% <0.00%> (+100.00%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The modification of this PR includes the contents in 743. Are there any dependencies between the two PRs? If not, it should be developed based on master branch.
The modification of this PR includes the contents in 743. Are there any dependencies between the two PRs? If not, it should be developed based on master branch.
Yes, it rely on 743. I'll make this WIP.
This PR can be continued now. After rebase, try to remain independent of other PR
lgtm