ks-devops icon indicating copy to clipboard operation
ks-devops copied to clipboard

Request to upgrade dependencies in go.mod

Open JohnNiang opened this issue 4 years ago • 3 comments

At present, our project dependencies defined in go.mod file that are too old may not be able to run in Kubernetes 1.22 correctly, especially when we create a webhook targeting for some CRDs.

I suggest upgrading dependencies related Kubernetes, such as sigs.k8s.io/controller-runtime, k8s.io/api and so on.

There was an example for that: https://github.com/kubesphere/s2ioperator/pull/163.

/kind enhancement

JohnNiang avatar Nov 11 '21 03:11 JohnNiang

@JohnNiang: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

At present, our project dependencies defined in go.mod file that are too old may not be able to run in Kubernetes 1.22 correctly, especially when we create a webhook targeting for some CRDs.

I suggest upgrading dependencies related Kubernetes, such as sigs.k8s.io/controller-runtime, k8s.io/api and so on.

There was an example for that: https://github.com/kubesphere/s2ioperator/pull/163.

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Nov 11 '21 03:11 ks-ci-bot

So, let's continue our discussion here. I want to express whether there has been some tentative work before to help people who want to work on this PR figure out what needs to be done. @LinuxSuRen @kubesphere/sig-devops

lxm avatar Aug 05 '22 06:08 lxm

This is great to do the upgrade work. Because we will have enough to do the test work.

LinuxSuRen avatar Aug 05 '22 06:08 LinuxSuRen