console icon indicating copy to clipboard operation
console copied to clipboard

Published 20 hours ago • verified publisher icon kubesphere

feat: Support Basic FluxCD Application management

Open chengleqi opened this issue 2 years ago • 7 comments

What type of PR is this?

/kind feature /kind design /kind api-change

What this PR does / why we need it:

Hi guys. This is the frontend part of the FluxCD Integration plan https://github.com/kubesphere/ks-devops/issues/716. This is the Demo. Here is the TODOs.

Sorry. I have to say this code may has much "worst practice" in frontend area due to my poor frontend skills. If you are confuse about some lines of code please let me know at the first time.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Yes, It change the CDSMapper in the object.mapper.js

Additional documentation, usage docs, etc.:

chengleqi avatar Sep 20 '22 12:09 chengleqi

Hi @chengleqi. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Sep 20 '22 12:09 ks-ci-bot

/area devops

chengleqi avatar Sep 20 '22 12:09 chengleqi

/ok-to-test

harrisonliu5 avatar Sep 26 '22 02:09 harrisonliu5

/test ?

chengleqi avatar Sep 27 '22 06:09 chengleqi

@chengleqi: The following commands are available to trigger jobs:

  • /test pull-console-unit-test
  • /test pull-console-build
  • /test pull-console-preview-deploy

Use /test all to run the following jobs:

  • pull-console-unit-test
  • pull-console-build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Sep 27 '22 06:09 ks-ci-bot

/test all

chengleqi avatar Sep 27 '22 06:09 chengleqi

/assign @weili520

harrisonliu5 avatar Oct 19 '22 02:10 harrisonliu5

/lgtm

weili520 avatar Oct 20 '22 02:10 weili520

LGTM label has been added.

Git tree hash: c9507bd6f78db53df11801db2e22d117e5fbf892

ks-ci-bot avatar Oct 20 '22 02:10 ks-ci-bot

/approve

harrisonliu5 avatar Oct 24 '22 06:10 harrisonliu5

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chengleqi, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Oct 24 '22 06:10 ks-ci-bot