console icon indicating copy to clipboard operation
console copied to clipboard

添加readme中的node版本要求以及支持windows下yarn serve的跨平台运行

Open zhujiaxin opened this issue 2 years ago • 4 comments

What type of PR is this?

/kind documentation

What this PR does / why we need it:

在windows版本yarn serve会因为没有添加cross-env无法运行,node因为node-sass的版本,需要限制在12和13版本中

Which issue(s) this PR fixes:

Fixes # None

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:

None

zhujiaxin avatar Aug 24 '22 15:08 zhujiaxin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhujiaxin To complete the pull request process, please assign zheng1 after the PR has been reviewed. You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Aug 24 '22 15:08 ks-ci-bot

Hi @zhujiaxin. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Aug 24 '22 15:08 ks-ci-bot

/assign @zheng1

zhujiaxin avatar Aug 24 '22 15:08 zhujiaxin

please use English in this issue, Thanks.

harrisonliu5 avatar Sep 29 '22 07:09 harrisonliu5

Thanks for your contribution, the package.json is modified, so this PR should be closed soon.

harrisonliu5 avatar Nov 25 '22 02:11 harrisonliu5