console icon indicating copy to clipboard operation
console copied to clipboard

refactor: Reuse the git repository selector on the Pipeline and CD page

Open bunnymiao opened this issue 2 years ago • 9 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Reuse the git repository selector on the Pipeline and CD page

Which issue(s) this PR fixes:

Fixes #606

Special notes for reviewers:

image

image

image

image

image

Does this PR introduced a user-facing change?

NONE

Additional documentation, usage docs, etc.:


bunnymiao avatar Aug 02 '22 03:08 bunnymiao

I have tested it with the following image:

After creating a new code repo, select it automatically. ✅ Use svn code repo directly. ✅ Use git repo.✅ Create same code repo with different name and select one of them✅ select code repo in CD page✅

bunnymiao avatar Aug 02 '22 03:08 bunnymiao

/lgtm

harrisonliu5 avatar Aug 02 '22 07:08 harrisonliu5

LGTM label has been added.

Git tree hash: f8b0efd543c33a8198bfdec8d723a431b92e044a

ks-ci-bot avatar Aug 02 '22 07:08 ks-ci-bot

/area console

LinuxSuRen avatar Aug 02 '22 08:08 LinuxSuRen

Please help us to test this with the following image:

surenpi/ks-console:refactor-select-repo

LinuxSuRen avatar Aug 03 '22 08:08 LinuxSuRen

/hold

LinuxSuRen avatar Aug 04 '22 06:08 LinuxSuRen

/area devops

LinuxSuRen avatar Aug 11 '22 05:08 LinuxSuRen

/unhold

bunnymiao avatar Aug 23 '22 06:08 bunnymiao

test passed

yudong2015 avatar Aug 29 '22 03:08 yudong2015

/lgtm

EliChen95 avatar Aug 30 '22 10:08 EliChen95

@EliChen95: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Aug 30 '22 10:08 ks-ci-bot

/lgtm /approve

harrisonliu5 avatar Sep 07 '22 02:09 harrisonliu5

LGTM label has been added.

Git tree hash: cea5bb69d11fc6362650da06aa4b36f922831999

ks-ci-bot avatar Sep 07 '22 02:09 ks-ci-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bunnymiao, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Sep 07 '22 02:09 ks-ci-bot