console icon indicating copy to clipboard operation
console copied to clipboard

fix: Appdeploy schemaform support select

Open SongJXin opened this issue 2 years ago • 7 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

For fixed phrases, There will be no typing errors

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


add  field in  values.schema.json

      "render": "select",
      "options":  [{
        "label": "Always",
        "value": "Always"
      },{
        "label": "IfNotPresent",
        "value": "IfNotPresent"
      },{
        "label": "Never",
        "value": "Never"
      }],
     "defaultValue": "IfNotPresent",



SongJXin avatar Jun 27 '22 01:06 SongJXin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SongJXin To complete the pull request process, please assign patrick-luoyu after the PR has been reviewed. You can assign the PR to them by writing /assign @patrick-luoyu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Jun 27 '22 01:06 ks-ci-bot

Hi @SongJXin. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Jun 27 '22 01:06 ks-ci-bot

/ok-to-test

harrisonliu5 avatar Jul 08 '22 07:07 harrisonliu5

@SongJXin please modify the Git commit messages following the Conventional Commits 1.0.0, and input the release note. Thanks.

harrisonliu5 avatar Jul 08 '22 07:07 harrisonliu5

/assign @weili520

harrisonliu5 avatar Aug 17 '22 02:08 harrisonliu5

@SongJXin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Aug 25 '22 15:08 ks-ci-bot

@SongJXin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Aug 25 '22 15:08 ks-ci-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SongJXin To complete the pull request process, please assign patrickluoyu after the PR has been reviewed. You can assign the PR to them by writing /assign @patrickluoyu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Nov 25 '22 02:11 ks-ci-bot

/lgtm

weili520 avatar Jan 09 '23 05:01 weili520

LGTM label has been added.

Git tree hash: 8eb419e52c654f4db8821f0617a4b187bb80f66b

ks-ci-bot avatar Jan 09 '23 05:01 ks-ci-bot

/approve

harrisonliu5 avatar Oct 18 '23 02:10 harrisonliu5

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, SongJXin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Oct 18 '23 02:10 ks-ci-bot

Thank you for your contribution.

harrisonliu5 avatar Oct 18 '23 02:10 harrisonliu5