console
console copied to clipboard
fix: Appdeploy schemaform support select
What type of PR is this?
/kind feature
What this PR does / why we need it:
For fixed phrases, There will be no typing errors
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
None
Additional documentation, usage docs, etc.:
add field in values.schema.json
"render": "select",
"options": [{
"label": "Always",
"value": "Always"
},{
"label": "IfNotPresent",
"value": "IfNotPresent"
},{
"label": "Never",
"value": "Never"
}],
"defaultValue": "IfNotPresent",
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SongJXin
To complete the pull request process, please assign patrick-luoyu after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrick-luoyu
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Hi @SongJXin. Thanks for your PR.
I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
@SongJXin please modify the Git commit messages following the Conventional Commits 1.0.0, and input the release note. Thanks.
/assign @weili520
@SongJXin: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@SongJXin: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SongJXin
To complete the pull request process, please assign patrickluoyu after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickluoyu
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/lgtm
LGTM label has been added.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: harrisonliu5, SongJXin
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [harrisonliu5]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Thank you for your contribution.