console
console copied to clipboard
kubesphere
PERF: hide table action menu when project is terminating
What type of PR is this?
/kind feature
What this PR does / why we need it:
If you modify a project which is terminating, you will get a error Message。
Which issue(s) this PR fixes:
Fixes # None
Special notes for reviewers:
@24sama
Does this PR introduced a user-facing change?
@OrangeBao: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: OrangeBao
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @OrangeBao. Thanks for your PR.
I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@harrisonliu5 is this pr 'lgtm'?
Consider to the augmentability i'd suggest that we'd better not delete it, because the operation of the button cause nothing when we have deleted the ns and deleting it may causing other problems. If oneday we could support the"undelete" feature,the buttun is useful.
This PR will be closed soon, thank you for your contribution, thank you.