community icon indicating copy to clipboard operation
community copied to clipboard

Update ZH-CN Localization Task.md

Open reneeteng opened this issue 4 years ago • 11 comments

Added PR links.

reneeteng avatar Oct 31 '20 06:10 reneeteng

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 06c8cbd Update ZH-CN Localization Task.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ks-ci-bot avatar Oct 31 '20 06:10 ks-ci-bot

please sign off your pr by using -s like

git commit -a -s

rayzhou2017 avatar Oct 31 '20 09:10 rayzhou2017

hi @reneeteng , I'm wondering if you can take some time to fix the dco issues.

LinuxSuRen avatar Dec 29 '20 14:12 LinuxSuRen

hi @rayzhou2017 and @FeynmanZhou, as we can see here. It's very easy to make some conflicts. Because all people need to update one file. So I'm wondering if we can use an alternative solution to manage these tasks. For example, convert these tasks into issues.

LinuxSuRen avatar Dec 29 '20 14:12 LinuxSuRen

hi @rayzhou2017 and @FeynmanZhou, as we can see here. It's very easy to make some conflicts. Because all people need to update one file. So I'm wondering if we can use an alternative solution to manage these tasks. For example, convert these tasks into issues.

Yes. The key point is we have to reminder contributors to sign-off commits in advance. Otherwise, our contributors may still have problems when submitting PR to any repo.

FeynmanZhou avatar Dec 29 '20 15:12 FeynmanZhou

hi @reneeteng , I'm wondering if you can take some time to fix the dco issues.

Sorry for the late reply. What should I do now?

reneeteng avatar Jul 14 '21 09:07 reneeteng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reneeteng To complete the pull request process, please assign calvinyv after the PR has been reviewed. You can assign the PR to them by writing /assign @calvinyv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ks-ci-bot avatar Jul 19 '21 01:07 ks-ci-bot

/assign @calvinyv

reneeteng avatar Jul 19 '21 01:07 reneeteng

/lgtm

calvinyv avatar Jul 19 '21 01:07 calvinyv

Any updates?

/cc @kubesphere/sig-docs

LinuxSuRen avatar Aug 16 '21 10:08 LinuxSuRen

/lgtm /approve

FeynmanZhou avatar Apr 15 '22 09:04 FeynmanZhou