kubeslice-controller icon indicating copy to clipboard operation
kubeslice-controller copied to clipboard

chore(): Use k8s 1.32 client libs

Open tamalsaha opened this issue 6 months ago • 2 comments

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] Does this PR requires documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have tested it for all user roles.
  • [ ] I have added all the required unit test cases.

Does this PR introduce a breaking change for other components like worker-operator?


tamalsaha avatar Jun 04 '25 19:06 tamalsaha

Hey @tamalsaha did you run make build ? there are errors with your changes.

kubeslice-controller/apis/controller/v1alpha1/cluster_webhook.go:53:2: invalid field type: interface{GroupVersionKindFor(obj k8s.io/apimachinery/pkg/runtime.Object) (k8s.io/apimachinery/pkg/runtime/schema.GroupVersionKind, error); IsObjectNamespaced(obj k8s.io/apimachinery/pkg/runtime.Object) (bool, error); RESTMapper() k8s.io/apimachinery/pkg/api/meta.RESTMapper; Scheme() *k8s.io/apimachinery/pkg/runtime.Scheme; sigs.k8s.io/controller-runtime/pkg/client.Reader; sigs.k8s.io/controller-runtime/pkg/client.Writer; sigs.k8s.io/controller-runtime/pkg/client.StatusClient; sigs.k8s.io/controller-runtime/pkg/client.SubResourceClientConstructor}

gourishkb avatar Jun 06 '25 05:06 gourishkb

I was just using go install -v ./... which was working ok. make build should be ok now.

tamalsaha avatar Jun 06 '25 08:06 tamalsaha