testkube-dashboard icon indicating copy to clipboard operation
testkube-dashboard copied to clipboard
verified publisher icon kubeshop

feat: select secrets

Open pavloburchak opened this issue 2 years ago • 6 comments

This PR...

Changes

Fixes

  • https://github.com/kubeshop/testkube/issues/3209

How to test it

screenshots

Checklist

  • [ ] tested locally
  • [ ] added new dependencies
  • [ ] updated the docs
  • [ ] added a test

pavloburchak avatar Oct 11 '23 21:10 pavloburchak

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:45am

vercel[bot] avatar Oct 11 '23 21:10 vercel[bot]

Description Screenshot
Looks like the Git source is not displayed for Tests, but I'm not sure if it's related to the ticket Zrzut ekranu 2023-10-13 o 13 38 54
I'm not sure if we should show "No options" for empty Zrzut ekranu 2023-10-13 o 13 44 31
There is no option to clear the username/token Zrzut ekranu 2023-10-13 o 13 45 34
The /secrets endpoint returns 404 on demo.testkube.dev - do we have already API for that? Zrzut ekranu 2023-10-13 o 13 46 26

rangoo94 avatar Oct 13 '23 11:10 rangoo94

Description Screenshot Looks like the Git source is not displayed for Tests, but I'm not sure if it's related to the ticket Zrzut ekranu 2023-10-13 o 13 38 54 I'm not sure if we should show "No options" for empty Zrzut ekranu 2023-10-13 o 13 44 31 There is no option to clear the username/token Zrzut ekranu 2023-10-13 o 13 45 34 The /secrets endpoint returns 404 on demo.testkube.dev - do we have already API for that? Zrzut ekranu 2023-10-13 o 13 46 26

  1. Not relatad to this PR
  2. Do you want it to be hidden?
  3. Should there be?
  4. Yes we have, but not released

pavloburchak avatar Oct 16 '23 10:10 pavloburchak

  1. Not relatad to this PR
  2. Do you want it to be hidden?
  3. Should there be?
  4. Yes we have, but not released
  1. Created follow-up ticket: https://github.com/kubeshop/testkube/issues/4470
  2. @fivenp, what do you think?
  3. It should be, the User may put there data accidentally, and may want to delete it. Earlier you had "Clear username" / "Clear token" links
  4. Looks like the /secrets endpoint is available only when User will set enableSecretsEndpoint in the Helm Chart (here). @fivenp, how should we perform, when we cannot read secrets?

rangoo94 avatar Oct 17 '23 10:10 rangoo94

@rangoo94 I will add ability to clear the values

pavloburchak avatar Oct 17 '23 10:10 pavloburchak

@pavloburchak, I'm not sure if @fivenp sent it to you, but looks like the Figma is updated and includes all of that: https://www.figma.com/file/asfUPepLHtyutWWR0pNGfK/Testkube-V2?type=design&node-id=3982-22830&mode=design

Of course, the "Log Parsing" has a higher priority for now though, so just adding it here for information completeness.

rangoo94 avatar Oct 18 '23 07:10 rangoo94