monokle icon indicating copy to clipboard operation
monokle copied to clipboard

Helm/Kustomize panels should be disabled in cluster view

Open olensmar opened this issue 2 years ago • 4 comments

When I load resources from my cluster I expect the Helm / Kustomize panels to be disabled since they don't reflect any content in my cluster - currently I can still see the kustomizations/helm-charts of my last viewed local resources and preview them (which exits cluster mode)

olensmar avatar Jun 23 '22 13:06 olensmar

what about this other issue https://github.com/kubeshop/monokle/issues/1983 ?

or maybe the ability to quickly compare a chart / kustomization with the cluster resources?

I'm thinking of the following workflows:

  1. Load Cluster Mode
  2. Go to Helm pane
  3. Hover a values file and see a "Compare" quick action
  4. Click on it and then the Compare modal opens up
  5. One side would be the cluster resources that were loaded and the other side would be the preview resources

What do you think?

devcatalin avatar Jun 24 '22 09:06 devcatalin

thanks @devcatalin - good point - that's a really nice workflow that would work for both kustomize and helm - i guess we could only remove the "preview" action for kustomizations/helm-charts to avoid my above scenario?

In regard to #1983 - could that be in a separate "Cluster Content" panel? Or should we add info about deployed helm-charts to the helm panel somehow!? @julioramosest what do you think?

olensmar avatar Jun 27 '22 14:06 olensmar

I don't think having with a separate panel will be the right way to do, because we might have other features (panels/tabs) affected by the Cluster Mode. Maybe we should look into how we can inform the user which panels are affected by Cluster Mode and then continue with this issue.

devcatalin avatar Jun 29 '22 13:06 devcatalin

agree with @devcatalin - I proposed something for https://github.com/kubeshop/monokle/issues/2023 (see comment there)

julioramosest avatar Jun 29 '22 15:06 julioramosest

Is this already fixed?

chargio avatar Mar 24 '23 14:03 chargio