monokle icon indicating copy to clipboard operation
monokle copied to clipboard

Adapt application for zoomed state

Open DmitryEremenko opened this issue 3 years ago • 1 comments

We need to change all font sizes from px to em to adapt them for zoomed in\out state

DmitryEremenko avatar Feb 03 '22 13:02 DmitryEremenko

hey @DmitryEremenko ! I did not have any experience with FE before, but I'm keen to take this one. What's the base for px value now? Also, do I understand correctly I should change only .css files or the .tsx ones should also be converted to em?

kruczyna avatar Feb 03 '22 14:02 kruczyna

I want to work on this issue.

DivvSaxena avatar Oct 20 '22 06:10 DivvSaxena

Hello @DivvSaxena,

Thank you for wanting to contribute to Monokle. The issue will be assigned to you.

If you have any questions just let us know.

Good luck 🤞🏻

topliceanurazvan avatar Oct 20 '22 06:10 topliceanurazvan

Can you send me the location of the file

DivvSaxena avatar Oct 20 '22 06:10 DivvSaxena

@DivvSaxena there is not just one location of a file, we need to check all the files containing css with px size and convert them to em. We need to be careful so that the size in px will remain the same as it is right now in default zoom.

topliceanurazvan avatar Oct 20 '22 06:10 topliceanurazvan

Since this refactoring has a big impact on Monokle ( some things might become broken and would create lots of bugs ) and we would not benefit too much - even not at all - from converting px to rem, we will close the issue for now.

topliceanurazvan avatar Oct 24 '22 10:10 topliceanurazvan