helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon kubeshop

fix: allow external NATS

Open rangoo94 opened this issue 1 year ago • 3 comments

Pull request description

  • Allow passing external NATS details even when nats.enabled: false (so the NATS server is not deployed)
  • Allow passing external NATS server with nats.uri

Fixes

  • https://github.com/kubeshop/testkube/issues/4848

Checklist (choose whats happened)

  • [ ] breaking change! (describe)
  • [ ] tested locally
  • [ ] tested on cluster
  • [ ] added new dependencies
  • [ ] updated the docs
  • [ ] added a test

rangoo94 avatar Jan 02 '24 11:01 rangoo94

hey @rangoo94! Thanks for the PR! Could you please re-create it to go into develop branch first?

ypoplavs avatar Jan 09 '24 12:01 ypoplavs

@rangoo94 @vsukhin Hey, this in would be quite helpful to. Is there anything blocking it (except for rebasing against develop) from getting released? Thanks a lot!

And seeing that the NATS configuration was removed from the testkube-operator values file: am I correct in assuming that it was never intended to be included there and that the operator does not interact with NATS?

frederikb avatar Feb 29 '24 20:02 frederikb

bump on this, any chance of this getting merged in?

seanuleh avatar Sep 03 '24 06:09 seanuleh