botkube icon indicating copy to clipboard operation
botkube copied to clipboard

Ignoring a namespace for jobs ignores it also for deployments

Open juissi-t opened this issue 2 years ago • 1 comments

Description

We're using Botkube version 0.12.4. Our config file includes resources for deployments and jobs, similar but with one exception: a couple more namespaces are ignored for jobs than for deployments. Whenever a deployment is updated in the namespace where changes to jobs are ignored, we get no notification for the changes done. But if we remove the namespace from being ignored, we do get notifications for both jobs and deployments.

Expected behavior

When ignoring a namespace for jobs, we expect to still get notifications for changes to deployments.

Actual behavior

When ignoring jobs in a namespace, it looks like Botkube also ignores changes to deployments.

Steps to reproduce

We deploy Botkube using Flux with the following config, which shows the Helm chart values:

---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: botkube
  namespace: botkube
spec:
  chart:
    spec:
      chart: botkube
      sourceRef:
        kind: HelmRepository
        name: infracloudio
      version: v0.12.4
  install: {}
  interval: 10m0s
  values:
    config:
      resources:
        - name: apps/v1/deployments
          namespaces:
            include:
              - all
            ignore:
              - amazon-cloudwatch
              - botkube
              - external-secrets
              - flux-system
              - kube-system
              - kyverno
              - monitoring
          events:
            - create
            - update
            - delete
            - error
          updateSetting:
            includeDiff: true
            fields:
              - spec.template.spec.containers[*].image
        - name: batch/v1/jobs
          namespaces:
            include:
              - all
            ignore:
              - amazon-cloudwatch
              - botkube
              - external-secrets
              - flux-system
              - kube-system
              - kyverno
              - monitoring
              - ingress-nginx
              - api-repo-workers
          events:
            - create
            - update
            - delete
            - error
          updateSetting:
            includeDiff: true
            fields:
              - spec.template.spec.containers[*].image
              - status.conditions[*].type
    communications:
      existingSecretName: botkube-communications
    serviceMonitor:
      enabled: true
      interval: 30s
    resources:
      limits:
        cpu: 200m
        memory: 128Mi
      requests:
        cpu: 100m
        memory: 128Mi

If we remove api-repo-workers from the list of ignored namespaces for jobs and re-deploy, we get notifications for changes in deployments in the namespace.

juissi-t avatar Aug 01 '22 13:08 juissi-t

@juissi-t Thanks for raising this 🙂.

Yup, I can also replicate this issue on Botkube version 0.12.4.

The good news is: this has been resolved against the latest dev build.

But, there is a caveat: the latest dev build uses an updated version of the Helm chart values.

You'll need to update your YAML config to be able to run this version of BotKube.

ezodude avatar Aug 02 '22 20:08 ezodude

Closing as resolved then 🙂 Final BotKube 0.13 version is just around the corner and you can try out 0.13 RC 🙂

pkosiec avatar Aug 25 '22 10:08 pkosiec

Thanks, I'll try out 0.13 next week. :smile:

juissi-t avatar Aug 25 '22 11:08 juissi-t