botkube icon indicating copy to clipboard operation
botkube copied to clipboard

Node getting ready is reported as an error

Open eddycharly opened this issue 4 years ago • 10 comments

image

Describe the bug The node getting ready is reported as an error.

eddycharly avatar Apr 20 '20 10:04 eddycharly

Isn't that expected? If Node is not ready, then we should get informed, right?

PrasadG193 avatar Apr 20 '20 11:04 PrasadG193

In this case the node is ready, i don’t think it should be considered an error

eddycharly avatar Apr 20 '20 11:04 eddycharly

I can see in the screenshot the status is NotReady. It might have happened that the node came back to Ready status?

PrasadG193 avatar Apr 20 '20 11:04 PrasadG193

In the screenshot the status is NodeReady not NotReady. Where do you see NotReady ?

eddycharly avatar Apr 20 '20 11:04 eddycharly

I am really sorry. It is NodeReady, I mistakenly ready it as NotReady. I am on smaller screen so coudn't find the difference :man_facepalming:. Thanks for reporting. This is not the expected behaviour. We have dedicated filter to extract node status from the event info. There must be something going wrong there

PrasadG193 avatar Apr 20 '20 11:04 PrasadG193

I would like to work on this. If someone had started already, kindly let me know.

codenio avatar Apr 21 '20 09:04 codenio

@codenio

I tried to setup from develop branch and tag v0.10.0, I didn't get any alert while node isn't NotReady or recover from NotReady to Ready state.

- name: node namespaces: include: - all ignore: - events: - create - update - delete - error updateSetting: includeDiff: true fields: - status.conditions[*].type

Also if we cordon/uncordon, evict we should get notifications. I didn't get any details in the documents.

coolpalani avatar May 08 '20 14:05 coolpalani

@coolpalani Is this issue remains unresolved.?

codenio avatar Jul 01 '20 08:07 codenio

is this unresolved..?

codenio avatar Oct 02 '20 09:10 codenio

I experience the same behavior, has anyone being able to solve this?

clementnuss avatar Jan 22 '22 15:01 clementnuss

Hi all, From what I could see on the old screenshot, the NodeReady event wasn't reported as error (green border was used for "create/info" events).

In recent Botkube versions (1.0+) You can exclude notifications based on reason, message and other patterns. Please see the docs here: https://docs.botkube.io/configuration/source/kubernetes. If such event is reported as error in the latest Botkube 1.5.0 version, please create another issue. Thank you!

pkosiec avatar Oct 10 '23 10:10 pkosiec