website icon indicating copy to clipboard operation
website copied to clipboard

[fr] Remove the `notitle` param that is not used anywhere else

Open SayakMukhopadhyay opened this issue 7 months ago • 5 comments
trafficstars

Description

This PR removes a front matter parameter called notitle from the fr language kubectl page. It also removes guards for the parameter.

This parameter has become obsolete and is not used anywhere else including the en version of the same page.

SayakMukhopadhyay avatar Mar 28 '25 13:03 SayakMukhopadhyay

/area web-development

SayakMukhopadhyay avatar Mar 28 '25 13:03 SayakMukhopadhyay

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 61a4152aac910c4fd4b8593b9e8c0846c47c3280
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67ffa30b8f349400088fdf0e
Deploy Preview https://deploy-preview-50298--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 28 '25 13:03 netlify[bot]

I just did an ./scripts/lsync.sh content/fr/docs/reference/kubectl/kubectl.md and it seems like the fr kubectl page needs to be synced too. What is the correct way of doing this? Should I also incorporate syncing in this PR? Or should I sync in a separate PR?

SayakMukhopadhyay avatar Mar 28 '25 13:03 SayakMukhopadhyay

I have attempted to sync the page content/fr/docs/reference/kubectl/kubectl.md using machine translation for all the needed bits as I don't know any French.

SayakMukhopadhyay avatar Mar 28 '25 15:03 SayakMukhopadhyay

/kind cleanup

SayakMukhopadhyay avatar Mar 30 '25 09:03 SayakMukhopadhyay

Hi @remyleone @katcosgrove Could you review this PR? to help with #41171 :)

seokho-son avatar May 05 '25 14:05 seokho-son

/LGTM /approve

remyleone avatar May 08 '25 09:05 remyleone

LGTM label has been added.

Git tree hash: ae0519088ce6e2865a049bef7fade9071e87e4ba

k8s-ci-robot avatar May 08 '25 09:05 k8s-ci-robot

Hi @divya-mohan0209

This PR needs approval from sig-docs-website-owners :) PTAL.

seokho-son avatar May 08 '25 09:05 seokho-son

/approve

divya-mohan0209 avatar May 08 '25 11:05 divya-mohan0209

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, remyleone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [divya-mohan0209]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 08 '25 11:05 k8s-ci-robot