website icon indicating copy to clipboard operation
website copied to clipboard

Remove link to GitHub @kubernetes/release-engineering page in Release Managers docs

Open khanhtc1202 opened this issue 8 months ago • 11 comments

Description

Remove the link to GitHub @kubernetes/release-engineering page in Release Managers docs. This means to team mention (as text), should not provide link to prevent misleading.

Issue

NONE

khanhtc1202 avatar Mar 19 '25 11:03 khanhtc1202

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit d68065feda54f977ee647065cb8b8bb2f920b712
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/68028225a9b76a0008fcfc49
Deploy Preview https://deploy-preview-50150--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 19 '25 11:03 netlify[bot]

/lgtm Thank you for your contribution.

Ritikaa96 avatar Mar 19 '25 11:03 Ritikaa96

LGTM label has been added.

Git tree hash: a22a414a74669198e99be8900025f9b25ba70897

k8s-ci-robot avatar Mar 19 '25 11:03 k8s-ci-robot

This isn't meant to be a link, it's the tag you need to use to mention the team on GitHub. I'm not sure if we really want it to look like you need to go to the linked page to find what/who you need to mention.

In such case, what does this mean in the first place ( ref: https://github.com/kubernetes/website/blob/main/content/en/releases/release-managers.md?plain=1#L88 ) I think if both are meant to be the same, they should be the same.

khanhtc1202 avatar Mar 19 '25 13:03 khanhtc1202

I think that other one is incorrect too. This is a team tag, so you can do a team mention to notify the members of that team. Linking to the actual team makes it look like you are expected to follow the link to get the list of the individual members of the team to tag separately, but that is not the intent.

stmcginnis avatar Mar 19 '25 14:03 stmcginnis

@stmcginnis I got your point. Then, let me update the other to make it not a link to GitHub team page.

khanhtc1202 avatar Mar 20 '25 10:03 khanhtc1202

/lgtm

Thanks!

stmcginnis avatar Mar 20 '25 11:03 stmcginnis

LGTM label has been added.

Git tree hash: 650651d9c561841843affb0732fad216bd88dd35

k8s-ci-robot avatar Mar 20 '25 11:03 k8s-ci-robot

Hi @khanhtc1202 , please fix the commit message.

divya-mohan0209 avatar Mar 27 '25 12:03 divya-mohan0209

@khanhtc1202 : Checking in to see if you have any updates on this

divya-mohan0209 avatar Apr 16 '25 12:04 divya-mohan0209

Hi @divya-mohan0209 I updated the commit message, please check when you have time.

khanhtc1202 avatar Apr 18 '25 16:04 khanhtc1202

/retitle Remove link to Release Engineering teams page on GitHub in Release Managers docs

divya-mohan0209 avatar Apr 19 '25 04:04 divya-mohan0209

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 19 '25 04:04 k8s-ci-robot