website icon indicating copy to clipboard operation
website copied to clipboard

KEP-4205: update for alpha release in 1.33

Open haircommander opened this issue 9 months ago • 6 comments

Description

Issue

Closes: #

haircommander avatar Feb 25 '25 15:02 haircommander

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit f9ff985f416e50e0c327ac0deefecce7c293b32b
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f3f6b5a3f15a00082e310e

netlify[bot] avatar Feb 25 '25 15:02 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit f9ff985f416e50e0c327ac0deefecce7c293b32b
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f3f6b56692c400084fcc3a
Deploy Preview https://deploy-preview-49895--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 25 '25 15:02 netlify[bot]

Hello @haircommander :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

rayandas avatar Mar 25 '25 05:03 rayandas

Hi @rayandas, I've updated the PR with the documentation content. This PR is ready for review. PTAL. @haircommander Could you update the state of the PR from Draft to Ready for review?

roycaihw avatar Mar 25 '25 22:03 roycaihw

LGTM!

haircommander avatar Mar 26 '25 20:03 haircommander

Hello @roycaihw :wave:! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

Urvashi0109 avatar Apr 03 '25 11:04 Urvashi0109

/lgtm

One nit but it is not blocking.

https://github.com/kubernetes/website/pull/49895/files#r2027079949

Technical review is complete on this @Urvashi0109!

kannon92 avatar Apr 03 '25 14:04 kannon92

LGTM label has been added.

Git tree hash: 28ea715784c8a3c0b231281ecebe0b27b028def8

k8s-ci-robot avatar Apr 03 '25 14:04 k8s-ci-robot

@Princesso @RainbowMango Could you help review this PR? Thank you!

roycaihw avatar Apr 03 '25 21:04 roycaihw

@kannon92 Could you pleas give another lgtm? The previous one was removed because of a new commit. @tengqm The suggested changes were address. This could use another review. Thanks!

rayandas avatar Apr 08 '25 06:04 rayandas

/approve

tengqm avatar Apr 08 '25 09:04 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 08 '25 09:04 k8s-ci-robot

Giving an lgtm as we're near to the Docs Freeze deadline. It was lgtm-ed before however it was removed because of a commit which addressed the Docs review suggestions. /lgtm

rayandas avatar Apr 08 '25 14:04 rayandas

LGTM label has been added.

Git tree hash: 606c3d968671cc530395cdfea208967f3812b331

k8s-ci-robot avatar Apr 08 '25 14:04 k8s-ci-robot