website icon indicating copy to clipboard operation
website copied to clipboard

Add docs for PSAT for Kubelet Image Credential Providers alpha

Open aramase opened this issue 9 months ago • 8 comments

Doc update for KEP 4412: https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/4412-projected-service-account-tokens-for-kubelet-image-credential-providers/README.md KEP issue: https://github.com/kubernetes/enhancements/issues/4412

aramase avatar Feb 24 '25 19:02 aramase

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit 29dd7e642fd0f4fa8517c56e230d2168f7a2dfbe
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e4a6dc92a3d90008ae7c68

netlify[bot] avatar Feb 24 '25 19:02 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 29dd7e642fd0f4fa8517c56e230d2168f7a2dfbe
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e4a6dc3fff900008de742a
Deploy Preview https://deploy-preview-49884--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 24 '25 19:02 netlify[bot]

Hello @aramase :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

rayandas avatar Mar 25 '25 05:03 rayandas

/assign enj liggitt

aramase avatar Mar 25 '25 23:03 aramase

looks good overall, just a few suggestions

liggitt avatar Mar 26 '25 14:03 liggitt

lgtm for sig-auth

liggitt avatar Mar 26 '25 16:03 liggitt

/assign @tengqm

aramase avatar Mar 27 '25 23:03 aramase

Hello @aramase :wave:! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as At risk for docs freeze. Thank you!

rayandas avatar Apr 03 '25 18:04 rayandas

Hello @aramase 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as At risk for docs freeze. Thank you!

@rayandas I have a lgtm from sig-auth changes (https://github.com/kubernetes/website/pull/49884#issuecomment-2755047900), waiting for lgtm + approve from the docs team.

aramase avatar Apr 03 '25 18:04 aramase

Upstream code changes seem complete. Technical LGTM. /lgtm /approve

tengqm avatar Apr 05 '25 09:04 tengqm

LGTM label has been added.

Git tree hash: 9e4e874c4e42b06e919fd9fcc763be6b6d0c2124

k8s-ci-robot avatar Apr 05 '25 09:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 05 '25 09:04 k8s-ci-robot