website
website copied to clipboard
Add a blog:Create enhancing-kubernetes-event-management-custom-aggregation.md
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: rezmoss / name: Rez Moss (160446cc443aa74b272578c3d116c9dbdfa754f9)
Welcome @rezmoss!
It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/website has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 160446cc443aa74b272578c3d116c9dbdfa754f9 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/681e5a101748280008750dd2 |
| Deploy Preview | https://deploy-preview-49457--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @rezmoss
We're trying to pair up blog article authors, so that the first reviews are done across two authors who both have a PR to publish.
Would you be willing to review https://github.com/kubernetes/contributor-site/pull/564 ? If so, follow our review process. The guidance there may also help you update this PR so that your reviewer need not provide any feedback.
Hi @rezmoss
We're trying to pair up blog article authors, so that the first reviews are done across two authors who both have a PR to publish.
Would you be willing to review kubernetes/contributor-site#564 ? If so, follow our review process. The guidance there may also help you update this PR so that your reviewer need not provide any feedback.
sure @sftim glad to help, will look into that based on the guideline
The article is very well written, proposing a useful yet simple solution to monitor your cluster events, I just added a couple of comments to make it even better and enahnce the clarity of some points that could be misunderstood. Good piece @rezmoss! 🚀
thx @graz-dev for the review and recommendation,I've addressed most
@sftim thx for review and suggestion, I've addressed most
There's a lot of code here. Can you outline how this will be relevant to the typical audience for the Kubernetes blog?
If you can convince us (blog editors and their helpers) that it's a good fit, I think we can publish it.
@sftim I think this article fits the Kubernetes blog since it's a technical blog, and I've seen similar content published before (https://kubernetes.io/blog/2024/04/24/validating-admission-policy-ga/ & https://kubernetes.io/blog/2024/05/01/cri-streaming-explained/) my goal was to share something useful for the Kubernetes comm since I'm an active/happy user and passionate about the project.
That said, I totally understand if it's not the right fit, no pressure at all, I'll respect the editors' and maintainers' judgment since they know what works best for the audience, thanks again for reviewing my submission!
@rezmoss I suggest just a word change. As @sftim the article should be helpful for the K8s community. Personally I found it really relevant and well written what I can suggest to make it even better is to highlight the need trying to answer the question: Why I have to build a custom events management aggregation? How Can I benefit from that? to do so I suggest you to add a real use-case where this aggregation could be helpful. I know that it could be implicit for experieced enginners but for novices it helps to let the understand the potential of the implementation and justify all the code example written in this piece. Adding the real use case you could outline the problem, how you approach to the problem without a custom aggregation system and what change when you build it highlighting the benefits.
@sftim @rezmoss what do you think about that?
Thanks for the thoughtful feedback @graz-dev
Totally see how adding a real-world use case could make the post easier to get into, especially for folks new to Kubernetes
my only worry is it might make the post longer and a bit more complex since explaining it well might need more context and code
happy to add it though if you think it still fits the blog’s style and audience
let me know what you think before i make changes
Thanks for the thoughtful feedback @graz-dev Totally see how adding a real-world use case could make the post easier to get into, especially for folks new to Kubernetes my only worry is it might make the post longer and a bit more complex since explaining it well might need more context and code happy to add it though if you think it still fits the blog’s style and audience let me know what you think before i make changes
Hi @rezmoss I think you could add just an example of how this solution can be useful in the real world without adding more code. 😁
Thanks for the thoughtful feedback @graz-dev Totally see how adding a real-world use case could make the post easier to get into, especially for folks new to Kubernetes my only worry is it might make the post longer and a bit more complex since explaining it well might need more context and code happy to add it though if you think it still fits the blog’s style and audience let me know what you think before i make changes
Hi @rezmoss I think you could add just an example of how this solution can be useful in the real world without adding more code. 😁
thx @graz-dev , added a few words on how this solution can be useful in the real world
We'd rather not promote using the legacy API that this example code suggests using. Please amend the code to use
events.k8s.io/v1instead.I know this is extra work, but it's important.
Thx @lmktfy , code updated , all minor styles applied
Hey @rezmoss the article now looks good to me! I left just two suggestions, please fix them.
Sure @graz-dev , fixed
LGTM label has been added.
@rezmoss thanks for this. Can you squash it down to 1 commit?
@lmktfy done
LGTM label has been added.
/approve
We'll need to liaise with release Comms about a date. I would like the Start Sidecar First article to go out before this one; it dovetails with an earlier article.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lmktfy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/blog/OWNERS~~ [lmktfy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment