website
website copied to clipboard
[WIP] Align to Docsy theme
Redo the custom theme to be closer to vanilla Docsy.
Here's a preview
Helps with issue https://github.com/kubernetes/website/issues/41171
/area web-development
This PR is too large to merge as-is.
/hold until it is small enough to be reviewable as a single change (eg size/XL or smaller)
I will carve off smaller PRs that are reviewable.
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 3e511355baf1057d4f126d08dc952c1fff169148 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e54e28033413000876aaca |
| Deploy Preview | https://deploy-preview-48363--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hello @sftim
For the localization-specific aspect, I compared the English version and Korean version of "Concepts" page:
https://deploy-preview-48363--kubernetes-io-main-staging.netlify.app/docs/concepts/
https://deploy-preview-48363--kubernetes-io-main-staging.netlify.app/ko/docs/concepts/
And here are what I found:
In top navbar,
- Korean alt texts (or the title of each page) of "๋ฌธ์(Documentation)" and "๋ธ๋ก๊ทธ(Blog)" are displayed, which is not in English version.
And it seems that this affects
- the menu entries not positioned as intended
- the top navbar thicker than original.
- The "Search this site" input, "Edit this page" and "Create child page" links are hidden by the thick top navbar
- other menu entries ("ํํธ๋(Partners)", "์ปค๋ฎค๋ํฐ(Community)", "์ฌ๋ก ์ฐ๊ตฌ(Case Studies)") not displayed
- the order of menu entries are different in Korean and English version;
- in English page: "Documentation" - "Blog" - "Training" - "Partners" - ... - [Version Selector] - [Language Selector]
- in Korean page: "๋ฌธ์(Documentation)" - "๊ต์ก(Training)" - "๋ธ๋ก๊ทธ(Blog)" - [Other entries missing] - [Version Selector] - [Language Selector]
And the feedback section is not translated.
These are the points I found.
PTAL. ๐
Thanks @jihoon-seo
For some of these, we are dependent on localizations to do front matter updates. For example the menu front matter item in https://github.com/kubernetes/website/blob/main/content/en/docs/home/_index.md?plain=1#L13 vs https://github.com/kubernetes/website/blob/main/content/ko/docs/home/_index.md?plain=1#L13
That will (should) fix the top menu. I'll try this myself and might send in a PR against Korean.
Hey Tim, are you still planning to break this PR into smaller ones. I have been thinking that getting the alignment done first can make the 0.7 upgrade a bit easier.
In which case, I can help with the carving off into smaller PRs. Unless you already plan to do it of course.
Hey Tim, are you still planning to break this PR into smaller ones. I have been thinking that getting the alignment done first can make the 0.7 upgrade a bit easier.
I already have one PRsplit from this and awaiting review; for example:
- https://github.com/kubernetes/website/pull/48258
as well as others - see https://github.com/kubernetes/website/pulls/sftim - that I need to rebase before they're ready for reviews.
You're welcome to carve some more off. I'll follow up via Slack.
Thanks, excellent work Tim!
For the localization-specific aspect, I compared the English version and Korean version of "Concepts" page: ...
Let me comment the Japanese version,
I'm not sure if this is a problem unique to Japanese, but it looks like the navbar no longer fits on the screen. Most of the other issues are the same as in Korean. If necessary, I can create a PR for the Japanese localization, Thanks!!
ref. https://deploy-preview-48363--kubernetes-io-main-staging.netlify.app/ja/docs/concepts/
PRs to fix the menus (for localizations) are welcome. Please send the pull request against main.
Sharing a comment on #41171 about the menu display issue. ๐ (Korean localization)
https://github.com/kubernetes/website/issues/41171#issuecomment-2653045316
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Superseded by PR https://github.com/kubernetes/website/pull/50665
/close