website icon indicating copy to clipboard operation
website copied to clipboard

WIP: Add checkpoint subresource to Kublet authorization doc

Open SimonBaeumer opened this issue 1 year ago • 4 comments

Description

This PR adds the checkpoint subresource to the kubelet authorization documentation.

SimonBaeumer avatar Sep 20 '24 10:09 SimonBaeumer

Welcome @SimonBaeumer!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 20 '24 10:09 k8s-ci-robot

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 2e6514c264a454a2a5ff1d58ecadd3209ae15462
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ed4b02cfcdb0000821c4e7
Deploy Preview https://deploy-preview-48012--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 20 '24 10:09 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit d86469d52b00c11178c36d014b634e48fddc5a38
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ed7a3784aa1e00083a8255
Deploy Preview https://deploy-preview-48012--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 20 '24 10:09 netlify[bot]

@kubernetes/sig-node-pr-reviews does this look technically correct?

sftim avatar Sep 30 '24 14:09 sftim

Additional source context in the kubelet. The subresource is for authentication is overwritten here for specific paths such as checkpointing or stats: https://github.com/kubernetes/kubernetes/blob/da8ffcd1dc30f2e204ae22aaaf85feea90a5e2c4/pkg/kubelet/server/auth.go#L98-L110

SimonBaeumer avatar Oct 01 '24 12:10 SimonBaeumer

/lgtm

haircommander avatar Oct 02 '24 17:10 haircommander

LGTM label has been added.

Git tree hash: a110568c4617cf64306369b38bb8f700ef0aff6b

k8s-ci-robot avatar Oct 02 '24 17:10 k8s-ci-robot

/approve

tengqm avatar Oct 03 '24 04:10 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 03 '24 04:10 k8s-ci-robot