kubernetes
Updated container garbage collection with accurate information
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign princesso for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | e661ab0cb4a95caa52c53d3bf54aaa8651d8c40d |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ecf727b594800007af69ee |
| Deploy Preview | https://deploy-preview-48001--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
thanks! content wise it looks good, I just have a couple of stylistic nits
@haircommander, Thanks for the review and suggestions. I have updated the content with your suggestions, PTAL!
Thnks for the review @haircommander, @esotsal
/assign @Princesso Assigning to @Princesso for approval, PTAL!
I think sig-node leaders may be able to clarify this.
Hello @kubernetes/sig-node-leads, @kubernetes/sig-node-bugs, we would appreciate your feedback to ensure the accuracy of these proposed changes. Thanks!
@T-Lakshmi: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-node-pr-reviews.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @kubernetes/sig-node-pr-reviews
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@T-Lakshmi: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-node-pr-reviews.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @kubernetes/sig-node-pr-reviews
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I think sig-node leaders may be able to clarify this.
Hello @kubernetes/sig-node-leads, @kubernetes/sig-node-bugs, we would appreciate your feedback to ensure the accuracy of these proposed changes. Thanks!
/cc @SergeyKanzhelev @haircommander WDYT ?
Added PR to sig node weekly meeting Agenda. https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit?tab=t.0
@SergeyKanzhelev @mrunalp @haircommander Please have a look!
Added PR to sig node weekly meeting Agenda. https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit?tab=t.0
@SergeyKanzhelev @mrunalp @haircommander Please have a look!
Sorry, I wasn't looking at the deprecations around this in a while. It will simplify reviews if you can provide easy to check links on what and where we announced was deprecated.
I will likely have time to look at this only after KubeCon
It will simplify reviews if you can provide easy to check links on what and where we announced was deprecated.
This PR was created as response to this comment discussed in sig-node some time ago. Googling i found deprecation is mentioned here With git blame found deprecation comment has been commited 7 years ago in 1.9.0 here
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
It will simplify reviews if you can provide easy to check links on what and where we announced was deprecated.
This PR was created as response to this comment discussed in sig-node some time ago. Googling i found deprecation is mentioned here With git blame found deprecation comment has been commited 7 years ago in 1.9.0 here
/remove-lifecycle rotten
@SergeyKanzhelev did above answered to your original question?
Saw your https://github.com/kubernetes/kubernetes/pull/129391#issuecomment-2738261675 , can you please elaborate? Do you propose to add the "quoted" additional information in @T-Lakshmi commit or ?
@SergeyKanzhelev @mrunalp @haircommander - would one of you like to review this? You can also nominate a different contributor.
@T-Lakshmi, please take a look at the feedback offered so far.
You can explain why it's not right, but please try to respond to it. (Or, if you no longer have capacity to move this PR forward, that's OK too but we'd like to know).
Hey @lmktfy, Thanks for reminding this. Extremely sorry for not responding on it as i am on long vacation and won't be able to spend time here. I request can some one please take ownership on it move this PR forward.
As @T-Lakshmi has mentioned in her comment regarding her inability to continue with the PR, please consider raising a tracking issue if the docs still need to be updated. We can follow through on the work there. Closing this PR for now. /close
@divya-mohan0209: Closed this PR.
In response to this:
As @T-Lakshmi has mentioned in her comment regarding her inability to continue with the PR, please consider raising a tracking issue if the docs still need to be updated. We can follow through on the work there. Closing this PR for now. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.