website
website copied to clipboard
Fix project logo overlapping with other parts of nav bar
Fixes : #47889
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | e583516083ba046d00d246b3e275ffd4bc451330 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66eac2d3c8871e0008bd4bc3 |
| Deploy Preview | https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
As discussed in the related issue, I have managed the size of the search box. Attached is the screen shot of the deployed navbar.
Deployment preview: https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app/
/retitle Fix project logo overlapping with other parts of nav bar
LGTM label has been added.
/assign @tengqm
Tested on MacOS with Firefox, Chrome and Safari.
This seems to have solved the issue.
How do we know this is a good choice of text size?
I'm not a fan of magic numbers either, but it looks good in this case. We can revisit if needed.
/approve
Oops, I can't approve web code updates, so an additional lgtm instead:
/lgtm
/approve
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nate-double-u
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [nate-double-u]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment