website icon indicating copy to clipboard operation
website copied to clipboard

Fix project logo overlapping with other parts of nav bar

Open thisisharrsh opened this issue 1 year ago • 5 comments
trafficstars

Fixes : #47889

thisisharrsh avatar Sep 18 '24 12:09 thisisharrsh

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit e583516083ba046d00d246b3e275ffd4bc451330
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66eac2d3c8871e0008bd4bc3
Deploy Preview https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 18 '24 12:09 netlify[bot]

As discussed in the related issue, I have managed the size of the search box. Attached is the screen shot of the deployed navbar.  Screenshot from 2024-09-18 17-49-00

thisisharrsh avatar Sep 18 '24 12:09 thisisharrsh

Deployment preview: https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app/

thisisharrsh avatar Sep 18 '24 12:09 thisisharrsh

/retitle Fix project logo overlapping with other parts of nav bar

sftim avatar Sep 18 '24 13:09 sftim

LGTM label has been added.

Git tree hash: 7fc1545a7ffba32b973ad29da71be7e9069da11b

k8s-ci-robot avatar Oct 01 '24 17:10 k8s-ci-robot

/assign @tengqm

sftim avatar Oct 02 '24 13:10 sftim

Tested on MacOS with Firefox, Chrome and Safari.

This seems to have solved the issue.

Screenshot 2024-11-19 at 2 10 49 PM Screenshot 2024-11-19 at 2 10 32 PM Screenshot 2024-11-19 at 2 10 24 PM

How do we know this is a good choice of text size?

I'm not a fan of magic numbers either, but it looks good in this case. We can revisit if needed.

/approve

nate-double-u avatar Nov 19 '24 22:11 nate-double-u

Oops, I can't approve web code updates, so an additional lgtm instead:

/lgtm

nate-double-u avatar Nov 19 '24 22:11 nate-double-u

/approve

nate-double-u avatar Nov 20 '24 01:11 nate-double-u

/approve

nate-double-u avatar Nov 20 '24 02:11 nate-double-u

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 20 '24 02:11 k8s-ci-robot