website
website copied to clipboard
kubernetes
Revise search to align better with Docsy
This is a small bit of change that (only slightly) helps us adopt Docsy. The associated JavaScript files are all moved to assets, allowing build-time minification.
Think issue #41171, but the link is tenuous. I still recommend making the change.
/area web-development
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 38cec03c87c26b77d25b55b32beecd555d2d0f6c |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67abdcfb8b10860008fc6161 |
| Deploy Preview | https://deploy-preview-47975--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hmm, the style change you mention @dipesh-rawat doesn't match intent. I wonder if there's a tool to help uncover this kind of impact and test if it's a problem?
I don't have a fleet of browsers etc to try it out with.
@divya-mohan0209 if you have time to add your feedback, I'd appreciate that too.
The current implementation is not "resilient" enough when my screen width decreases. E.g.:
At ~1280px, I'm getting this:
At ~1130px, this:
After playing around this a bit, I'm offering a fix in https://github.com/kubernetes/website/pull/47975/commits/38c9000ffce7bea7b1eba60edcabecd63113f4fc (I've checked it in two browsers, Chrome & Firefox).
Personally, I also prefer the current search input design (on the left) in the sidebar as it is more visible. Was it an intentional change?
Sounds like this could use more work. We upgraded Docsy since I started this. /retitle [WIP] Revise search to align better with Docsy
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Will look wrong until https://github.com/kubernetes/website/pull/49630 has merged.
@sftim why? It seems to be fine (with an exception for the 90% width, which would be fixed by your PR).
P.S. Personally, I would also remove unnecessary left/right paddings to leave more space for the content itself. (If that sounds good, I can suggest a fix for it here.)
Maybe it's just an artefact of the width. I'll octopus them together and check.
If https://github.com/kubernetes/website/pull/49724 does a better job: great! This one can close.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.