website icon indicating copy to clipboard operation
website copied to clipboard

Promote LoadBalancerIPMode to GA

Open RyanAoh opened this issue 1 year ago • 11 comments

Update the docs about promoting LoadBalancerIPMode to GA.

xref: KEP kubernetes/kubernetes#127348

RyanAoh avatar Sep 15 '24 15:09 RyanAoh

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit 338c7b1347b9ea58b89384875d3b5d37885a043f
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66f0db681ac82300086d51c3

netlify[bot] avatar Sep 15 '24 15:09 netlify[bot]

/reopen

RyanAoh avatar Sep 15 '24 16:09 RyanAoh

@RyanAoh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 15 '24 16:09 k8s-ci-robot

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 557c4c059bc3ede001e6537c890c49ec9a66d4e2
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66e702dd0038a500087a6b22
Deploy Preview https://deploy-preview-47938--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 15 '24 16:09 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 338c7b1347b9ea58b89384875d3b5d37885a043f
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f0db68b4a7820008a2c67b
Deploy Preview https://deploy-preview-47938--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 15 '24 16:09 netlify[bot]

/sig network

sftim avatar Sep 15 '24 18:09 sftim

Please provide a link to the upstream source code change in the commit message.

tengqm avatar Sep 17 '24 01:09 tengqm

@tengqm I've updated the commit message.

RyanAoh avatar Sep 19 '24 12:09 RyanAoh

@tengqm I've updated the commit message.

@RyanAoh Please provide link to the source code change, not the KEP. KEPs are too wordy to track. What we want to ensure is that the upstream source code change is proposed and merged.

tengqm avatar Sep 19 '24 13:09 tengqm

@tengqm The PR of the upstream source code is kubernetes/kubernetes#127348. I've included it in both the Git commit message and the description of this PR.

RyanAoh avatar Sep 19 '24 14:09 RyanAoh

/approve /hold

Hold can be lifted when the upstream change has been merged.

tengqm avatar Sep 25 '24 03:09 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 25 '24 03:09 k8s-ci-robot

The upstream change https://github.com/kubernetes/kubernetes/pull/127348 has been merged. /hold cancel

RyanAoh avatar Oct 11 '24 02:10 RyanAoh

Looks good to me /lgtm

niranjandarshann avatar Oct 11 '24 05:10 niranjandarshann

LGTM label has been added.

Git tree hash: 306585fd993edc3b12c1b37cd2ce33044aff6ff4

k8s-ci-robot avatar Oct 11 '24 05:10 k8s-ci-robot