website icon indicating copy to clipboard operation
website copied to clipboard

Promote RetryGenerateName to GA in 1.32

Open jpbetz opened this issue 1 year ago • 5 comments

Description

Promote the RetryGenerateName feature to GA

/sig api-machinery

/hold until https://github.com/kubernetes/kubernetes/pull/127093 merges

jpbetz avatar Sep 03 '24 14:09 jpbetz

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 31aba2f8c6f15383b110936beb88f578e0c4fd7a
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f4b48bf70602000846362c
Deploy Preview https://deploy-preview-47770--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 03 '24 15:09 netlify[bot]

/milestone 1.32

reylejano avatar Sep 03 '24 18:09 reylejano

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit 31aba2f8c6f15383b110936beb88f578e0c4fd7a
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66f4b48bbf47f200084f2b2c

netlify[bot] avatar Sep 23 '24 18:09 netlify[bot]

I'd like to have name generation very briefly mentioned in https://kubernetes.io/docs/concepts/overview/working-with-objects/names/, along with the fact that the API server tries more than once to generate a name but may give up eventually.

I've added a paragraph to the page. PTAL

jpbetz avatar Sep 23 '24 18:09 jpbetz

All the kubernetes/kubernetes and kubernetes/enhnacements changes for this promotion have merged. This can merge when ready.

jpbetz avatar Sep 26 '24 15:09 jpbetz

/approve /hold cancel

tengqm avatar Sep 26 '24 21:09 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 26 '24 21:09 k8s-ci-robot

This just needs LGTM to merge. The implementation is merged.

@sftim Would you be willing to LGTM?

jpbetz avatar Oct 01 '24 18:10 jpbetz

Friendly nudge that this is ready to merge

jpbetz avatar Oct 07 '24 18:10 jpbetz

/lgtm

tengqm avatar Oct 07 '24 23:10 tengqm

LGTM label has been added.

Git tree hash: 2fb42e6b5ee07c1235459d3193fe804c2b592d64

k8s-ci-robot avatar Oct 07 '24 23:10 k8s-ci-robot