website icon indicating copy to clipboard operation
website copied to clipboard

Documenting audit annotation to transforming response object

Open Ritikaa96 opened this issue 1 year ago • 11 comments

Documenting audit annotations which records latency in transforming response object

  • apiserver.latency.k8s.io/transform-response-object
  • apiserver.latency.k8s.io/serialize-response-object
  • apiserver.latency.k8s.io/response-write

Partially Fixes: https://github.com/kubernetes/website/issues/29479

Ritikaa96 avatar Aug 12 '24 05:08 Ritikaa96

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 12 '24 05:08 k8s-ci-robot

/sig docs /sig auth /kind feature

Ritikaa96 avatar Aug 12 '24 05:08 Ritikaa96

@Ritikaa96: The label(s) sig/ cannot be applied, because the repository doesn't have them.

In response to this:

/sig docs /sig auth /kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 12 '24 05:08 k8s-ci-robot

Reference taken from audit.go and webhook.go

Ritikaa96 avatar Aug 12 '24 05:08 Ritikaa96

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 3bcd4e444e7b2b562eb7966b1b89562fda16dfeb
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b999f19d25510008a637ae
Deploy Preview https://deploy-preview-47450--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 05:08 netlify[bot]

/sig api-machinery /remove-sig auth

aramase avatar Aug 12 '24 16:08 aramase

Any update on this?

Ritikaa96 avatar Sep 19 '24 11:09 Ritikaa96

Waiting for the reviews for this one. Is there any changes i need to make?

Ritikaa96 avatar Nov 29 '24 16:11 Ritikaa96

@shannonxtreme @tengqm PTAL

Ritikaa96 avatar Jan 30 '25 17:01 Ritikaa96

Is there anything pending for this PR? PTAL @shannonxtreme

Ritikaa96 avatar Mar 26 '25 12:03 Ritikaa96

I'll check on it today

shannonxtreme avatar Mar 26 '25 12:03 shannonxtreme

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 14 '25 01:05 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 12 '25 02:08 k8s-triage-robot

@Ritikaa96 PTAL at the suggestions by @shannonxtreme & address the merge conflict for proceeding with the review.

divya-mohan0209 avatar Aug 17 '25 03:08 divya-mohan0209

Closing as stale.

@Ritikaa96, thanks for your contribution. Feel free to reopen this if you want to continue the work.

/close

nate-double-u avatar Nov 07 '25 21:11 nate-double-u

@nate-double-u: Closed this PR.

In response to this:

Closing as stale.

@Ritikaa96, thanks for your contribution. Feel free to reopen this if you want to continue the work.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 07 '25 21:11 k8s-ci-robot